Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753384Ab1BHKtf (ORCPT ); Tue, 8 Feb 2011 05:49:35 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:28502 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753198Ab1BHKtd (ORCPT ); Tue, 8 Feb 2011 05:49:33 -0500 Date: Tue, 08 Feb 2011 19:49:11 +0900 From: Jaehoon Chung Subject: Re: [PATCH v4] dw_mmc: Add Synopsys DesignWare mmc host driver. In-reply-to: To: Will Newton Cc: Jaehoon Chung , Chris Ball , Linux Kernel list , linux-mmc@vger.kernel.org, Matt Fleming , linux-arm-kernel@lists.infradead.org Message-id: <4D511FA7.4040207@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-1 Content-transfer-encoding: 7BIT User-Agent: Thunderbird 2.0.0.24 (X11/20100317) References: <20101208115510.GD10998@console-pimps.org> <20101209064751.GA21128@void.printf.net> <20101209160157.GA28586@void.printf.net> <20101211192320.GA24430@void.printf.net> <4D354752.3030401@samsung.com> <4D50E4DD.4030500@samsung.com> X-OriginalArrivalTime: 08 Feb 2011 10:49:14.0824 (UTC) FILETIME=[D3C9AC80:01CBC77D] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1662 Lines: 51 Hi Will I'm probing dw_mmc on Samsung SoC... So i have some board specific data.. But i didn't want to add board specific data in dw_mmc.c I want to use get_cd()/get_wd()/init()...So i asked to you..:) If i need not the data information, i will not append them.. you're right, maybe "struct dw_mci" need not..(just example) And i think that need card_detect irq-handler function..if we use pdata->init..isn't? :) In future, if i need your help, can i ask to you? Onemore...Did you test the dw_mmc..? If you can answer, i want to know the performance.. Will Newton wrote: > On Tue, Feb 8, 2011 at 6:38 AM, Jaehoon Chung wrote: >> Hi Will.. >> >> I need your help for your code.. >> >> In dw_mmc.h, exist some function pointer.. >> >> int *get_ro(u32 slot_id); >> int *get_cd(u32 slot_id); >> ... >> >> Just only need slot_id?? >> If i need the "struct dw_mci", could i append the parameter? > > Yes, that should be possible. However I would like to reduce the > number of places the whole struct dw_mci > is passed around if possible, as the whole struct is usually not > needed and it exposes some driver internals. > > Which part of struct dw_mci do you need in the callback? > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/