Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754592Ab1BHWXi (ORCPT ); Tue, 8 Feb 2011 17:23:38 -0500 Received: from smtp.outflux.net ([198.145.64.163]:35885 "EHLO smtp.outflux.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753425Ab1BHWXh (ORCPT ); Tue, 8 Feb 2011 17:23:37 -0500 Date: Tue, 8 Feb 2011 14:23:04 -0800 From: Kees Cook To: Paul Bolle Cc: linux-kernel@vger.kernel.org, David Woodhouse , Arnd Bergmann , mtk.manpages@gmail.com Subject: Re: [PATCH v2 1/2] Export linux/syslog.h Message-ID: <20110208222304.GO1457@outflux.net> References: <1297203320.1748.14.camel@t41.thuisdomein> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1297203320.1748.14.camel@t41.thuisdomein> Organization: Canonical X-HELO: www.outflux.net Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 742 Lines: 24 Hi, Looks fine to me. On Tue, Feb 08, 2011 at 11:15:08PM +0100, Paul Bolle wrote: > Userspace programs (like util-linux' dmesg) still use magic numbers for > the klogctl function (glibc's interface to the syslog system call). > Exporting linux/syslog.h makes the more descriptive named constants > available as a single reference for these values. > > Signed-off-by: Paul Bolle Signed-off-by: Kees Cook -Kees -- Kees Cook Ubuntu Security Team -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/