Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755861Ab1BHWdF (ORCPT ); Tue, 8 Feb 2011 17:33:05 -0500 Received: from smtp.outflux.net ([198.145.64.163]:50011 "EHLO smtp.outflux.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753679Ab1BHWdD (ORCPT ); Tue, 8 Feb 2011 17:33:03 -0500 Date: Tue, 8 Feb 2011 14:32:51 -0800 From: Kees Cook To: Paul Bolle Cc: linux-kernel@vger.kernel.org, David Woodhouse , Arnd Bergmann , mtk.manpages@gmail.com, Serge Hallyn Subject: Re: [PATCH v2 2/2] man-pages: SYSLOG_ACTION_* constants are now exported Message-ID: <20110208223251.GP1457@outflux.net> References: <1297203340.1748.15.camel@t41.thuisdomein> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1297203340.1748.15.camel@t41.thuisdomein> Organization: Canonical X-HELO: www.outflux.net Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1617 Lines: 40 On Tue, Feb 08, 2011 at 11:15:34PM +0100, Paul Bolle wrote: > The kernel now exports . This makes the SYSLOG_ACTION_* > constants available to userspace. This allows to replace the magic > numbers used in this man page with (what should be) more descriptive > names. The quote form kernel/printk.c can now also be dropped. > > A few (more or less related) things were also fixed or changed: > - add a new sub section "The command types"; > - the (userspace) buffer is called bufp everywhere (and not buf); > - add some whitespace to all call descriptions; > - use "ignored" in some call descriptions (instead of "dummy"). > > Signed-off-by: Paul Bolle Acked-by: Kees Cook As an aside, it might be a good idea to send an additional patch (since it's logically separate from this) to update this portion of the man-page: EPERM An attempt was made to change console_loglevel or clear the kernel message ring buffer by a process without sufficient privi lege (more precisely: without the CAP_SYS_ADMIN capability). At least s/CAP_SYS_ADMIN/CAP_SYSLOG/, but probably include details about which options are considered privileged. Though that should probably go with including the description of CAP_SYSLOG in the "capabilities" man-page. -Kees -- Kees Cook Ubuntu Security Team -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/