Date: Tue, 08 Feb 2011 16:35:22 -0800 (PST)
Message-Id: <20110208.163522.232741523.davem@davemloft.net>
To: toshiharu-linux@dsn.okisemi.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, qi.wang@intel.com,
        yong.y.wang@intel.com, andrew.chih.howe.khor@intel.com,
        joel.clark@intel.com, kok.howg.ewe@intel.com,
        tomoya-linux@dsn.okisemi.com
Subject: Re: [PATCH] pch_gbe: Fix the issue that the receiving data is not
 normal.
From: David Miller <davem@davemloft.net>
In-Reply-To: <4D50FDAA.1060506@dsn.okisemi.com>
References: <4D50FDAA.1060506@dsn.okisemi.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 658
Lines: 19

From: Toshiharu Okada <toshiharu-linux@dsn.okisemi.com>
Date: Tue, 08 Feb 2011 17:24:10 +0900

> Hi Devid
> 
> I resubmit this patch modified.
> Please check them.

Your memcpy+memcpy sequences are equivalent to memmove(), please
use that instead.

I have to say this function is insanely complicated.  There seems
to be 16 different ways RX packets are processed.  I can't believe
that is needs to be like this.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/