Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756116Ab1BIBFZ (ORCPT ); Tue, 8 Feb 2011 20:05:25 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:56116 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755036Ab1BIBFY convert rfc822-to-8bit (ORCPT ); Tue, 8 Feb 2011 20:05:24 -0500 MIME-Version: 1.0 In-Reply-To: <201102090137.52697.rjw@sisk.pl> References: <1297081335-13631-1-git-send-email-broonie@opensource.wolfsonmicro.com> <201102082220.25240.rjw@sisk.pl> <201102090137.52697.rjw@sisk.pl> From: Linus Torvalds Date: Tue, 8 Feb 2011 17:04:31 -0800 Message-ID: Subject: Re: [PATCH 1/5] ACPI / PM: Move references to pm_flags into sleep.c To: "Rafael J. Wysocki" Cc: Ingo Molnar , Mark Brown , Len Brown , Alan Stern , linux-pm@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Andrew Morton , Dmitry Torokhov , linux-embedded@vger.kernel.org, Thomas Gleixner Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 699 Lines: 17 On Tue, Feb 8, 2011 at 4:37 PM, Rafael J. Wysocki wrote: > >> but maybe it would be about APM being enabled. Which is what the caller >> actually seems to care about and talks about for the failure case. Maybe >> you need separate functions for the "is APM enabled" case for the naming >> to make sense. Hmm? > > That sounds like a good idea. ?What about the following patch? This patch I have no problems with. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/