Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756190Ab1BICWQ (ORCPT ); Tue, 8 Feb 2011 21:22:16 -0500 Received: from sm-d311v.smileserver.ne.jp ([203.211.202.206]:17411 "EHLO sm-d311v.smileserver.ne.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753310Ab1BICWP (ORCPT ); Tue, 8 Feb 2011 21:22:15 -0500 Message-ID: <3F7E1C17407A45E3834BF70553CB294C@hacdom.okisemi.com> From: "Toshiharu Okada" To: "David Miller" Cc: , , , , , , , References: <4D512A27.2030406@dsn.okisemi.com> <20110208.164030.242137610.davem@davemloft.net> Subject: Re: [PATCH] pch_gbe: Fix the issue which a driver locks when rx offload is set by ethtool Date: Wed, 9 Feb 2011 11:04:11 +0900 MIME-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2900.5931 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5994 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 952 Lines: 32 From: David Miller Date: Tue, 08 Feb 2011 16:40:30 -0800 (PST) >> @@ -531,12 +533,8 @@ void pch_gbe_reinit_locked(struct pch_gbe_adapter >> *adapter) >> { >> struct net_device *netdev = adapter->netdev; >> >> - rtnl_lock(); >> - if (netif_running(netdev)) { >> - pch_gbe_down(adapter); >> - pch_gbe_up(adapter); >> - } >> - rtnl_unlock(); >> + pch_gbe_down(adapter); >> + pch_gbe_up(adapter); > >Are you sure you can just blindly delete the netif_running() check here? Yes, sure. pch_gbe_reinit_locked() is called after confirming of netif_running() except for pch_gbe_reset_task() function. This netif_running() was redundant. Best regards Toshiharu Okada(OKI semiconductor) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/