Date: Tue, 08 Feb 2011 22:57:02 -0800 (PST)
Message-Id: <20110208.225702.104076116.davem@davemloft.net>
To: toshiharu-linux@dsn.okisemi.com
Cc: netdev@vger.kernel.org, tomoya-linux@dsn.okisemi.com, qi.wang@intel.com,
        yong.y.wang@intel.com, andrew.chih.howe.khor@intel.com,
        joel.clark@intel.com, kok.howg.ewe@intel.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pch_gbe: Fix the issue which a driver locks when rx
 offload is set by ethtool
From: David Miller <davem@davemloft.net>
In-Reply-To: <3F7E1C17407A45E3834BF70553CB294C@hacdom.okisemi.com>
References: <4D512A27.2030406@dsn.okisemi.com>
	<20110208.164030.242137610.davem@davemloft.net>
	<3F7E1C17407A45E3834BF70553CB294C@hacdom.okisemi.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1072
Lines: 33

From: "Toshiharu Okada" <toshiharu-linux@dsn.okisemi.com>
Date: Wed, 9 Feb 2011 11:04:11 +0900

> From: David Miller <davem@davemloft.net>
> Date: Tue, 08 Feb 2011 16:40:30 -0800 (PST)
> 
>>> @@ -531,12 +533,8 @@ void pch_gbe_reinit_locked(struct pch_gbe_adapter 
>>> *adapter)
>>>  {
>>>  struct net_device *netdev = adapter->netdev;
>>>
>>> - rtnl_lock();
>>> - if (netif_running(netdev)) {
>>> - pch_gbe_down(adapter);
>>> - pch_gbe_up(adapter);
>>> - }
>>> - rtnl_unlock();
>>> + pch_gbe_down(adapter);
>>> + pch_gbe_up(adapter);
>>
>>Are you sure you can just blindly delete the netif_running() check here?
> 
> Yes, sure.
> pch_gbe_reinit_locked() is called after confirming of netif_running() except 
> for pch_gbe_reset_task() function.
> This netif_running() was redundant.

Thanks for explaining, applied, thank you.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/