Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755465Ab1BIUow (ORCPT ); Wed, 9 Feb 2011 15:44:52 -0500 Received: from mail.linux-iscsi.org ([67.23.28.174]:53568 "EHLO linux-iscsi.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752618Ab1BIUou (ORCPT ); Wed, 9 Feb 2011 15:44:50 -0500 Subject: Re: Linux 2.6.38-rc4 (target_core: rmmod GP fault) From: "Nicholas A. Bellinger" To: James Bottomley Cc: Linus Torvalds , Randy Dunlap , Joel Becker , scsi , Linux Kernel Mailing List , Christoph Hellwig In-Reply-To: <1297283335.3016.48.camel@mulgrave.site> References: <20110209092851.bba6c40c.randy.dunlap@oracle.com> <1297281744.18212.44.camel@haakon2.linux-iscsi.org> <1297282433.3016.43.camel@mulgrave.site> <1297282835.18212.57.camel@haakon2.linux-iscsi.org> <1297283335.3016.48.camel@mulgrave.site> Content-Type: text/plain Date: Wed, 09 Feb 2011 12:44:45 -0800 Message-Id: <1297284285.18212.71.camel@haakon2.linux-iscsi.org> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2432 Lines: 63 On Wed, 2011-02-09 at 14:28 -0600, James Bottomley wrote: > On Wed, 2011-02-09 at 12:20 -0800, Nicholas A. Bellinger wrote: > > On Wed, 2011-02-09 at 14:13 -0600, James Bottomley wrote: > > > Firstly, could we get the serious bug fixes identified and separated > > > from the general enhancement updates, so they can go in a fixes tree > > > without depending on enhancements? The former category would include > > > the /proc interface removal, since we don't want the legacy interface to > > > be in a released kernel. > > > > > > > Everything in those two series should be considered bug fixes and > > immediate for-38 mainline material. > > Things like this: > > target: remove EXTRA_CFLAGS > target: Remove unnecessary container_of() pointer check > target: Remove unnecessary se_clear_dev_ports legacy code > target: Remove spurious double cast from structure macro accessors > target: Convert TMR REQ/RSP definitions to target namespace This is an important one, as using w/o TMR_* prefixed definitions for task management response/response defs, we run into problems with existing include/scsi/scsi.h message codes. > target: Minor sparse warning fixes and annotations > target: Remove unneeded test of se_cmd > > Are not serious bug fixes. I could go either way on some of the error path changes. > Yes, these others are minor items that have been submitted by people (hch, roland, jesper, danc) who have been reviewing target code since it was merged for .38-rc1. Considering how minor these are I would prefer to have these merged, than deferring for-39. If not, then I will need to respin tree w/o their cleanups if what you prefer to be sent to Linus for-38, there are 3 other bugfix patches in the upstream LIO tree that I have been saving for-38-rc5 since for-38-rc4 was cut(considering the two outstanding series). I would like to have these included as well. Do you want me to send them all to the linux-scsi list again...? --nab > James > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/