Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754958Ab1BIWoW (ORCPT ); Wed, 9 Feb 2011 17:44:22 -0500 Received: from xenotime.net ([72.52.115.56]:58486 "HELO xenotime.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753616Ab1BIWoV (ORCPT ); Wed, 9 Feb 2011 17:44:21 -0500 Date: Wed, 9 Feb 2011 14:44:19 -0800 From: Randy Dunlap To: Greg KH Cc: Matthew Garrett , linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org Subject: Re: [PATCH] Platform: add Samsung Laptop platform driver Message-Id: <20110209144419.f673facf.rdunlap@xenotime.net> In-Reply-To: <20110209224006.GA11202@kroah.com> References: <20110209224006.GA11202@kroah.com> Organization: YPO4 X-Mailer: Sylpheed 2.7.1 (GTK+ 2.16.6; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2236 Lines: 58 On Wed, 9 Feb 2011 14:40:06 -0800 Greg KH wrote: > From: Greg Kroah-Hartman > > This adds the samsung-laptop driver to the kernel. It now supports > all known Samsung laptops. > > Signed-off-by: Greg Kroah-Hartman > --- > Documentation/ABI/testing/sysfs-driver-samsung-laptop | 19 > drivers/platform/x86/Kconfig | 13 > drivers/platform/x86/Makefile | 1 > drivers/platform/x86/samsung-laptop.c | 768 ++++++++++++++++++ > 4 files changed, 801 insertions(+) > > Matthew, this is a copy of the latest version in the linux-next tree of the > driver. Once it has been accepted into your tree, I'll delete the > staging driver. Or, if you want to give your ACK, I can just move the > driver from staging into this directory in my tree, which will properly > preserve the history of the code. > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig > index d163bc2..da9aed1 100644 > --- a/drivers/platform/x86/Kconfig > +++ b/drivers/platform/x86/Kconfig > @@ -654,4 +654,17 @@ config XO1_RFKILL > Support for enabling/disabling the WLAN interface on the OLPC XO-1 > laptop. > > +config SAMSUNG_LAPTOP > + tristate "Samsung Laptop driver" > + depends on RFKILL && BACKLIGHT_CLASS_DEVICE && X86 This entire Kconfig file already depends on X86, so the "&& X86" above is redundant. > + ---help--- > + This module implements a driver for a wide range of different > + Samsung laptops. It offers control over the different > + function keys, wireless LED, LCD backlight level, and > + sometimes provides a "performance_control" sysfs file to allow > + the performance level of the laptop to be changed. > + > + To compile this driver as a module, choose M here: the module > + will be called samsung-laptop. > + > endif # X86_PLATFORM_DEVICES --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/