Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755651Ab1BIWvK (ORCPT ); Wed, 9 Feb 2011 17:51:10 -0500 Received: from cavan.codon.org.uk ([93.93.128.6]:37097 "EHLO cavan.codon.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751792Ab1BIWvI (ORCPT ); Wed, 9 Feb 2011 17:51:08 -0500 Date: Wed, 9 Feb 2011 22:50:56 +0000 From: Matthew Garrett To: Greg KH Cc: Randy Dunlap , linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org Subject: Re: [PATCH] Platform: add Samsung Laptop platform driver Message-ID: <20110209225056.GA25009@srcf.ucam.org> References: <20110209224006.GA11202@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110209224006.GA11202@kroah.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: mjg59@cavan.codon.org.uk X-SA-Exim-Scanned: No (on cavan.codon.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 517 Lines: 14 \o/ A quick glance suggests that the firmware interface is an abomination and really there's no reason for them not to have used an existing interface of some sort, but that's par for the course. I'll review it properly now. -- Matthew Garrett | mjg59@srcf.ucam.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/