Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Tue, 12 Dec 2000 20:18:44 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Tue, 12 Dec 2000 20:18:34 -0500 Received: from mercury.ukc.ac.uk ([129.12.21.10]:11154 "EHLO mercury.ukc.ac.uk") by vger.kernel.org with ESMTP id ; Tue, 12 Dec 2000 20:18:30 -0500 To: linux-kernel@vger.kernel.org Subject: Possible patch for reiserfs-3.6.22 against 2.4.0-test12 Mime-Version: 1.0 (generated by tm-edit 1.5) Content-Type: text/plain; charset=US-ASCII From: Adam Sampson Date: 13 Dec 2000 00:47:57 +0000 Message-ID: <873dftywn6.fsf@cartman.azz.net> Lines: 34 X-Mailer: Gnus v5.6.45/XEmacs 21.1 - "Carlsbad Caverns" Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Hiya. The latest reiserfs patch on ftp.namesys.com causes compilation errors against test12 due to the task queue changes. Does this look correct? --- fs/reiserfs/journal.c.orig Wed Dec 13 00:13:00 2000 +++ fs/reiserfs/journal.c Wed Dec 13 00:40:52 2000 @@ -1762,7 +1762,7 @@ ct->p_s_sb = p_s_sb ; ct->jindex = jindex ; ct->task_done = NULL ; - ct->task.next = NULL ; + INIT_LIST_HEAD(&ct->task.list); ct->task.sync = 0 ; ct->task.routine = (void *)(void *)reiserfs_journal_commit_task_func ; ct->self = ct ; @@ -1813,7 +1813,7 @@ lock_kernel() ; while(1) { - while(reiserfs_commit_thread_tq) { + while(TQ_ACTIVE(reiserfs_commit_thread_tq)) { run_task_queue(&reiserfs_commit_thread_tq) ; } It does at least compile with these changes, but I haven't yet tested it. Looking at run_task_queue, it would appear that the while() is now redundant, but could someone who knows confirm/deny this? -- Adam Sampson azz@gnu.org - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/