Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756203Ab1BJAEd (ORCPT ); Wed, 9 Feb 2011 19:04:33 -0500 Received: from fgwmail5.fujitsu.co.jp ([192.51.44.35]:39363 "EHLO fgwmail5.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755146Ab1BJAEc (ORCPT ); Wed, 9 Feb 2011 19:04:32 -0500 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 Date: Thu, 10 Feb 2011 08:58:23 +0900 From: KAMEZAWA Hiroyuki To: Ryota Ozaki Cc: linux-mm@kvack.org, Andrew Morton , Rik van Riel , Andrea Arcangeli , Hugh Dickins , linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: Fix out-of-date comments which refers non-existent functions Message-Id: <20110210085823.2f99b81c.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <1297262537-7425-1-git-send-email-ozaki.ryota@gmail.com> References: <1297262537-7425-1-git-send-email-ozaki.ryota@gmail.com> Organization: FUJITSU Co. LTD. X-Mailer: Sylpheed 3.1.0 (GTK+ 2.10.14; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2570 Lines: 71 On Wed, 9 Feb 2011 23:42:17 +0900 Ryota Ozaki wrote: > From: Ryota Ozaki > > do_file_page and do_no_page don't exist anymore, but some comments > still refers them. The patch fixes them by replacing them with > existing ones. > > Signed-off-by: Ryota Ozaki Acked-by: KAMEZAWA Hiroyuki It seems there are other ones ;) == Searched full:do_no_page (Results 1 - 3 of 3) sorted by relevancy /linux-2.6-git/arch/alpha/include/asm/ H A D cacheflush.h 66 /* This is used only in do_no_page and do_swap_page. */ /linux-2.6-git/arch/avr32/mm/ H A D cache.c 116 * This one is called from do_no_page(), do_swap_page() and install_page(). /linux-2.6-git/mm/ H A D memory.c 2121 * and do_anonymous_page and do_no_page can safely check later on). 2319 * do_no_page is protected similarly. > --- > mm/memory.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > I'm not familiar with the codes very much, so the fix may be wrong. > > diff --git a/mm/memory.c b/mm/memory.c > index 31250fa..3fbf32a 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -2115,10 +2115,10 @@ EXPORT_SYMBOL_GPL(apply_to_page_range); > * handle_pte_fault chooses page fault handler according to an entry > * which was read non-atomically. Before making any commitment, on > * those architectures or configurations (e.g. i386 with PAE) which > - * might give a mix of unmatched parts, do_swap_page and do_file_page > + * might give a mix of unmatched parts, do_swap_page and do_nonlinear_fault > * must check under lock before unmapping the pte and proceeding > * (but do_wp_page is only called after already making such a check; > - * and do_anonymous_page and do_no_page can safely check later on). > + * and do_anonymous_page can safely check later on). > */ > static inline int pte_unmap_same(struct mm_struct *mm, pmd_t *pmd, > pte_t *page_table, pte_t orig_pte) > @@ -2316,7 +2316,7 @@ reuse: > * bit after it clear all dirty ptes, but before a racing > * do_wp_page installs a dirty pte. > * > - * do_no_page is protected similarly. > + * __do_fault is protected similarly. > */ > if (!page_mkwrite) { > wait_on_page_locked(dirty_page); > -- > 1.7.2.3 > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/