Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751273Ab1BJMUW (ORCPT ); Thu, 10 Feb 2011 07:20:22 -0500 Received: from wolverine01.qualcomm.com ([199.106.114.254]:13487 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750766Ab1BJMUU (ORCPT ); Thu, 10 Feb 2011 07:20:20 -0500 X-IronPort-AV: E=McAfee;i="5400,1158,6252"; a="73906286" Message-ID: <4D53D7FE.9070206@codeaurora.org> Date: Thu, 10 Feb 2011 17:50:14 +0530 From: Trilok Soni User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.13) Gecko/20101207 Thunderbird/3.1.7 MIME-Version: 1.0 To: Eric Miao CC: Anirudh Ghayal , linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, rtc-linux@googlegroups.com, linux-arm-msm@vger.kernel.org, Dmitry Torokhov Subject: Re: [RFC v2 PATCH 1/7] matrix_keypad: Increase the max limit of rows and columns References: <1296568063-12010-1-git-send-email-aghayal@codeaurora.org> <1296568063-12010-2-git-send-email-aghayal@codeaurora.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1193 Lines: 33 Hi Dmitry, On 2/9/2011 1:32 PM, Eric Miao wrote: > On Tue, Feb 1, 2011 at 9:47 PM, Anirudh Ghayal wrote: >> From: Trilok Soni >> >> Some keyboard controller have support for more than >> 16 columns and rows. Moving this value to 32. >> >> Cc: Eric Miao >> Cc: Dmitry Torokhov >> Signed-off-by: Trilok Soni > > This looks good to me, as long as the bits don't exceed 256, which > is used in the #KEY() macro. So far, 32 looks to be a sane number > to me, unless we have further requirement to get this larger. > > Acked-by: Eric Miao > Are you going to pick up this patch only from the series you want us to get it submitted it separately? ---Trilok Soni -- Sent by a consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/