Subject: Re: [Patch] idle governor: Avoid lock acquisition to read pm_qos
 before entering idle
From: James Bottomley <James.Bottomley@suse.de>
To: Tim Chen <tim.c.chen@linux.intel.com>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>, mark gross <markgross@thegnar.org>,
        David Alan Gilbert <linux@treblig.org>, linux-kernel@vger.kernel.org,
        Len <len.brown@intel.com>, Andi Kleen <ak@linux.intel.com>,
        Arjan van de Ven <arjan@linux.intel.com>
In-Reply-To: <1297366384.2645.175.camel@schen9-DESK>
References: <1297300864.2645.128.camel@schen9-DESK>
	 <1297359914.4933.56.camel@mulgrave.site>
	 <1297366384.2645.175.camel@schen9-DESK>
Content-Type: text/plain; charset="UTF-8"
Date: Thu, 10 Feb 2011 14:37:43 -0600
Message-ID: <1297370263.4933.74.camel@mulgrave.site>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 920
Lines: 25

On Thu, 2011-02-10 at 11:33 -0800, Tim Chen wrote:
> On Thu, 2011-02-10 at 11:45 -0600, James Bottomley wrote:
> 
> > 
> > What you say is true as long as the value is 32 bits ... perhaps a note
> > of that should be made somewhere?
> > 
> 
> It seems like pm_qos_add_request, pm_qos_update_request only uses 32
> bits value.  Did I miss some cases where the target value for
> pm_qos_object be non-32 bit under some situation?

No ... I'm thinking of the future.  On the face of it, if we needed
larger quantities (like s64), the obvious approach would be to change
s32 to s64 which would fail ... horribly.  I was just suggesting a nice
reminder comment for this.

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/