Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757266Ab1BJWfl (ORCPT <rfc822;w@1wt.eu>);
	Thu, 10 Feb 2011 17:35:41 -0500
Received: from mail-wy0-f174.google.com ([74.125.82.174]:62208 "EHLO
	mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1757161Ab1BJWfj (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 10 Feb 2011 17:35:39 -0500
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=date:from:to:cc:subject:message-id:mail-followup-to:references
         :mime-version:content-type:content-disposition:in-reply-to
         :user-agent;
        b=cp7Z8q33MkLH4fuX5KHrQeNCKmRboXIx6Uhwjbmm4avPrKy6aQUHiFhmr2UCnFJmqm
         UTqcUqdiO2WyZ5HlHSrr3A8kCHlF0gOrbUZsiXpRpr/QdnF+CyDPnPUWsfONuAF5iK9w
         +MuUC3ZMgHHeRiQU+MjdCNxxQW9Xw4yJb4KyU=
Date: Thu, 10 Feb 2011 23:35:31 +0100
From: Ulf Magnusson <ulfalizer.lkml@gmail.com>
To: Michal Marek <mmarek@suse.cz>
Cc: linux-kbuild@vger.kernel.org, zippel@linux-m68k.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kconfig: undefined symbols can crash dependency loop
 detection
Message-ID: <20110210223529.GA19824@ulf>
Mail-Followup-To: Ulf Magnusson <ulfalizer.lkml@gmail.com>,
	Michal Marek <mmarek@suse.cz>, linux-kbuild@vger.kernel.org,
	zippel@linux-m68k.org, linux-kernel@vger.kernel.org
References: <20110204231611.GA9344@ulf>
 <4D54030B.5040407@suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <4D54030B.5040407@suse.cz>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2756
Lines: 81

On Thu, Feb 10, 2011 at 04:23:55PM +0100, Michal Marek wrote:
> On 5.2.2011 00:16, Ulf Magnusson wrote:
> > The Kconfig
> > 
> > config FOO
> > 	bool "FOO" if BAR
> > 	select BAR
> > 
> > has a dependency loop involving an undefined symbol BAR. This causes a
> > segfault in sym_check_print_recursive() as it assumes all symbols have a
> > non-null 'prop', which is not the case for undefined symbols. This is a
> > proposed fix.
> > 
> > Signed-off-by: Ulf Magnusson <ulfalizer.lkml@gmail.com>
> > ---
> >  scripts/kconfig/symbol.c |   32 ++++++++++++++++++++++++++++----
> >  1 files changed, 28 insertions(+), 4 deletions(-)
> > 
> > diff --git a/scripts/kconfig/symbol.c b/scripts/kconfig/symbol.c
> > index a796c95..81a217f 100644
> > --- a/scripts/kconfig/symbol.c
> > +++ b/scripts/kconfig/symbol.c
> > @@ -5,6 +5,7 @@
> >  
> >  #include <ctype.h>
> >  #include <stdlib.h>
> > +#include <stdio.h>
> >  #include <string.h>
> >  #include <regex.h>
> >  #include <sys/utsname.h>
> > @@ -972,6 +973,10 @@ static void sym_check_print_recursive(struct symbol *last_sym)
> >  	struct menu *menu = NULL;
> >  	struct property *prop;
> >  	struct dep_stack cv_stack;
> > +	const char *filename;
> > +	int lineno;
> > +	char undef_msg_buf[100];
> > +	int snprintf_size;
> >  
> >  	if (sym_is_choice_value(last_sym)) {
> >  		dep_stack_insert(&cv_stack, last_sym);
> > @@ -1001,18 +1006,37 @@ static void sym_check_print_recursive(struct symbol *last_sym)
> >  					break;
> >  			}
> >  		}
> > +
> > +		if (prop) {
> > +			filename = prop->file->name;
> > +			lineno = prop->lineno;
> > +		} else {
> > +			/* The dependency loop involves an undefined symbol.
> > +			 * Checking sym->name is probably unnecessary here, but
> > +			 * just to be on the safe side. */
> > +			snprintf_size = snprintf(undef_msg_buf,
> > +						 sizeof(undef_msg_buf),
> > +						 "<no file, %s is undefined>",
> > +						 sym->name ? sym->name :
> > +							     "<choice>");
> > +			if (snprintf_size > sizeof(undef_msg_buf))
> > +				undef_msg_buf[sizeof(undef_msg_buf) - 1] = '\0';
> > +			filename = undef_msg_buf;
> > +			lineno = 0;
> 
> Good catch. But as this handles a corner case involving a severely
> borken Kconfig file, I would simply do
> filename = "<unknown>";
> lineno = 0;
> and be done with it.
>
Yeah, it probably isn't very likely to occur in practise, though it
would also happen if a symbol selects an undefined symbol it depends on
via an enclosing menu or if.

Pick whatever version you prefer :)

/Ulf
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/