Date: Mon, 14 Feb 2011 12:05:28 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Henrik Kretzschmar <henne@nachtwindheim.de>
Cc: mingo@readhat.com, tglx@linutronix.de, hpa@zytor.com, x86@kernel.org,
        tj@kernel.org, yinghai@kernel.org, ak@linux.intel.com,
        robert.richter@amd.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] x86: move ioapic_irq_destination_types
Message-ID: <20110214110528.GD7140@elte.hu>
References: <1297677612-12405-1-git-send-email-henne@nachtwindheim.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1297677612-12405-1-git-send-email-henne@nachtwindheim.de>
User-Agent: Mutt/1.5.20 (2009-08-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1026
Lines: 45


* Henrik Kretzschmar <henne@nachtwindheim.de> wrote:

> +++ b/arch/x86/include/asm/apicdef.h
> @@ -426,4 +426,16 @@ struct local_apic {
>  #else
>   #define BAD_APICID 0xFFFFu
>  #endif
> +
> +enum ioapic_irq_destination_types {
> +	dest_Fixed = 0,
> +	dest_LowestPrio = 1,
> +	dest_SMI = 2,
> +	dest__reserved_1 = 3,
> +	dest_NMI = 4,
> +	dest_INIT = 5,
> +	dest__reserved_2 = 6,
> +	dest_ExtINT = 7
> +};

one very small request, while we are moving it could you please align the value
enumeration vertically? Something like:

enum ioapic_irq_destination_types {

	dest_Fixed		= 0,
	dest_LowestPrio		= 1,
	dest_SMI		= 2,
	dest__reserved_1	= 3,
	dest_NMI		= 4,
	dest_INIT		= 5,
	dest__reserved_2	= 6,
	dest_ExtINT		= 7
};

... would be much more readable, right?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/