Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753449Ab1BNLfi (ORCPT ); Mon, 14 Feb 2011 06:35:38 -0500 Received: from cantor2.suse.de ([195.135.220.15]:46471 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752990Ab1BNLfh (ORCPT ); Mon, 14 Feb 2011 06:35:37 -0500 Date: Mon, 14 Feb 2011 12:35:35 +0100 Message-ID: From: Takashi Iwai To: "J. Bruce Fields" Cc: Tino Keitel , Neil Brown , Trond Myklebust , linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: 2.6.38-rc3: kernel BUG at fs/nfsd/nfs4state.c:3132! In-Reply-To: References: <20110211152112.GA3005@fieldses.org> <20110211153702.GC3005@fieldses.org> <20110211160532.GD3005@fieldses.org> <20110211170036.GF3005@fieldses.org> <20110211174312.GH3005@fieldses.org> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3228 Lines: 81 At Fri, 11 Feb 2011 19:15:53 +0100, Takashi Iwai wrote: > > At Fri, 11 Feb 2011 12:43:12 -0500, > J. Bruce Fields wrote: > > > > On Fri, Feb 11, 2011 at 12:00:36PM -0500, J. Bruce Fields wrote: > > > On Fri, Feb 11, 2011 at 05:59:44PM +0100, Takashi Iwai wrote: > > > > At Fri, 11 Feb 2011 17:57:21 +0100, > > > > Takashi Iwai wrote: > > > > > > > > > > At Fri, 11 Feb 2011 17:12:33 +0100, > > > > > Takashi Iwai wrote: > > > > > > > > > > > > At Fri, 11 Feb 2011 11:05:32 -0500, > > > > > > J. Bruce Fields wrote: > > > > > > > > > > > > > > On Fri, Feb 11, 2011 at 05:01:18PM +0100, Takashi Iwai wrote: > > > > > > > > At Fri, 11 Feb 2011 10:37:02 -0500, > > > > > > > > J. Bruce Fields wrote: > > > > > > > > > > > > > > > > > > On Fri, Feb 11, 2011 at 04:29:56PM +0100, Takashi Iwai wrote: > > > > > > > > > > At Fri, 11 Feb 2011 10:21:12 -0500, > > > > > > > > > > J. Bruce Fields wrote: > > > > > > > > > > > Again, 2.6.38-rc4 does not have a BUG() on line 3132. Could you post > > > > > > > > > > > the full oops message from your machine? > > > > > > > > > > > > > > > > > > > > Well, on vanilla 2.6.38-rc4, it's in nfs4_preprocess_stateid_op(): > > > > > > > > > > if (filpp) { > > > > > > > > > > *filpp = find_readable_file(dp->dl_file); > > > > > > > > > > ==> BUG_ON(!*filpp); > > > > > > > > > > } > > > > > > > > > > > > > > > > > > Oh good grief, my apologies--I mistyped "38" as "28"! > > > > > > > > > > > > > > > > > > This looks like it could be a known delegation bug.... Would it be > > > > > > > > > possible for you to check whether this is reproduceable on > > > > > > > > > > > > > > > > > > git://linux-nfs.org/~bfields/topics.git for-2.6.38-incoming > > > > > > > > > > > > > > > > Hm, I couldn't pull it. > > > > > > > > > > > > > > > > % git pull 'git://linux-nfs.org/~bfields/topics.git' for-2.6.38-incoming > > > > > > > > fatal: The remote end hung up unexpectedly > > > > > > > > > > > > > > Should be linux-topics, apologies again: > > > > > > > > > > > > > > git://linux-nfs.org/~bfields/linux-topics.git for-2.6.38-incoming > > > > > > > > > > > > Thanks. I'm going to give it a try now. > > > > > > > > > > Looks good so far. I'll let you know if it's triggered again. > > > > > > > > Argh, too early to say. Now I got the same one. > > > > > > > > It seems that it's triggered when I start Firefox on NFS client > > > > machine. > > > > > > OK, thanks, I'll take a look. > > > > I think I see the problem.... Could you try fetching that branch again? > > > > git://linux-nfs.org/~bfields/linux-topics.git for-2.6.38-incoming > > > > (But I've only tested that it compiles so far.) > > Sorry, I already left my office and have no access to the machine. > I'll test it on Monday if Tino can't test it beforehand. I've been testing it for hours, and so far this looks good. FireFox starts and doesn't trigger BUG(). Thanks! Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/