Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755992Ab1BNQfq (ORCPT ); Mon, 14 Feb 2011 11:35:46 -0500 Received: from mail-qw0-f46.google.com ([209.85.216.46]:53954 "EHLO mail-qw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755202Ab1BNQfo (ORCPT ); Mon, 14 Feb 2011 11:35:44 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=mime-version:reply-to:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; b=oMFByZF1btGrRZ8/nFYRBU2yKS6O6botqdl/VgT7Ur8RvO/VPOzRyf64VsOjmCvisq GRh30P2vPFZJOD5TVqyMR1u9M3kZ1WDJc3UOsItwlrExZKCOWGHzPIbKDer4sTnzn0/l wZM6Zyy/Eg5OkWwlCv7kH4qqougQKKGhvWPTI= MIME-Version: 1.0 Reply-To: sedat.dilek@gmail.com In-Reply-To: <20110214162057.GI9869@sequoia.sous-sol.org> References: <20110214162057.GI9869@sequoia.sous-sol.org> Date: Mon, 14 Feb 2011 17:35:42 +0100 Message-ID: Subject: Re: Regression - Xorg start failed From: Sedat Dilek To: Chris Wright Cc: DRI , LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 948 Lines: 30 On Mon, Feb 14, 2011 at 5:20 PM, Chris Wright wrote: > * Sedat Dilek (sedat.dilek@googlemail.com) wrote: >> [ As I am not subscribed to both MLs and lazy to pick up all involved people ] >> >> Hi Chris, >> >> The original patch had also this part (see the revert in [1]): >> ... >> +#include >> ... >> >> Your new patch in [2] is missing it or is it not required? > > It was just a patch on top of the bad commit (47970b1b), the #include is > required. > > thanks, > -chris > OK, now I see. Might be good to push a v2 as the initial patch was reverted in the meantime? The explanations of the fixup patch were helpful (to me) and should be included. - Sedat - -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/