Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756057Ab1BNQgM (ORCPT ); Mon, 14 Feb 2011 11:36:12 -0500 Received: from bombadil.infradead.org ([18.85.46.34]:60989 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755709Ab1BNQgK (ORCPT ); Mon, 14 Feb 2011 11:36:10 -0500 Subject: Re: [PATCH 0/2] jump label: 2.6.38 updates From: Peter Zijlstra To: Jason Baron Cc: Mathieu Desnoyers , hpa@zytor.com, rostedt@goodmis.org, mingo@elte.hu, tglx@linutronix.de, andi@firstfloor.org, roland@redhat.com, rth@redhat.com, masami.hiramatsu.pt@hitachi.com, fweisbec@gmail.com, avi@redhat.com, davem@davemloft.net, sam@ravnborg.org, ddaney@caviumnetworks.com, michael@ellerman.id.au, linux-kernel@vger.kernel.org In-Reply-To: <20110214162947.GA3449@redhat.com> References: <1297452328.5226.89.camel@laptop> <1297460297.5226.99.camel@laptop> <1297536465.5226.108.camel@laptop> <20110214155113.GA2840@redhat.com> <1297699024.2401.12.camel@twins> <20110214160437.GB2840@redhat.com> <1297700754.5226.110.camel@laptop> <20110214162947.GA3449@redhat.com> Content-Type: text/plain; charset="UTF-8" Date: Mon, 14 Feb 2011 17:37:18 +0100 Message-ID: <1297701438.5226.113.camel@laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1040 Lines: 24 On Mon, 2011-02-14 at 11:29 -0500, Jason Baron wrote: > On Mon, Feb 14, 2011 at 05:25:54PM +0100, Peter Zijlstra wrote: > > > > > > I remember that atomic_t is defined in types.h now rather than atomic.h. > > > Any reason why you should keep including atomic.h from jump_label.h ? > > > > Ooh, shiny.. we could probably move the few atomic_{read,inc,dec} users > > in jump_label.h into out of line functions and have this sorted. > > > > inc and dec sure, but atomic_read() for the disabled case needs to be > inline.... D'0h yes of course, I was thinking about jump_label_enabled(), but there's still the static_branch() implementation to consider. We could of course cheat implement our own version of atomic_read() in order to avoid the whole header mess, but that's not pretty at all -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/