Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756383Ab1BOWsV (ORCPT ); Tue, 15 Feb 2011 17:48:21 -0500 Received: from cantor2.suse.de ([195.135.220.15]:59734 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752706Ab1BOWsT (ORCPT ); Tue, 15 Feb 2011 17:48:19 -0500 Date: Tue, 15 Feb 2011 23:48:14 +0100 (CET) From: Jiri Kosina To: Dmitry Torokhov Cc: Benjamin Tissoires , Stephane Chatty , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] hidinput: kernel oops in out_cleanup in function hidinput_connect In-Reply-To: <20110215164614.GA18862@core.coreip.homeip.net> Message-ID: References: <1297780870-4006-1-git-send-email-benjamin.tissoires@enac.fr> <20110215164614.GA18862@core.coreip.homeip.net> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 854 Lines: 26 On Tue, 15 Feb 2011, Dmitry Torokhov wrote: > > Goto out_cleanup infers a kernel oops: hidinput_disconnect calls > > input_unregister_driver to all members of hid->inputs. > > However, hidinput already has been added to hid->inputs even > > though input_register_device was not called. > > > > Signed-off-by: Benjamin Tissoires > > Yep, well spotted. > > Reviewed-by: Dmitry Torokhov Indeed, thanks a lot for spotting this Benjamin. Apparently this codepath is not excercised too heavily (which is good :) ). Applied. -- Jiri Kosina SUSE Labs, Novell Inc. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/