Date: Thu, 17 Feb 2011 01:53:50 +0000
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Tyler Hicks <tyhicks@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org
Subject: please, remove the abuse of vfs_path_lookup() in ecryptfs
Message-ID: <20110217015350.GH22723@ZenIV.linux.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 949
Lines: 20

	commit 21edad32205e97dc7ccb81a85234c77e760364c8 (
ecryptfs: dont call lookup_one_len to avoid NULL nameidata) is badly
misguided.  The last thing we need is extra places where nameidata is
passed around.

	The current code is simply wrong - it's bypassing dcache
lookups in new_lower_dentry().  Besides, abuse of vfs_path_lookup()
here is a Bad Idea(tm).  No, filesystems are *not* allowed to die
if ->d_revalidate()/->lookup()/->create() are called with NULL
nameidata.  Eventually these methods will lose nameidata * anyway -
starting with ->d_revalidate() in the next cycle at the latest
(i.e. if we run into something really stinky in RCU mess, it might
happen before -final).

	Please revert that.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/