Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757763Ab1BRApg (ORCPT ); Thu, 17 Feb 2011 19:45:36 -0500 Received: from mail-wy0-f174.google.com ([74.125.82.174]:37557 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751300Ab1BRAp2 (ORCPT ); Thu, 17 Feb 2011 19:45:28 -0500 Date: Fri, 18 Feb 2011 00:45:22 +0000 From: Jamie Iles To: John Linn Cc: Jamie Iles , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux@arm.linux.org.uk, catalin.marinas@arm.com, glikely@secretlab.ca, arnd@arndb.de Subject: Re: [PATCH V3 3/4] ARM: Xilinx: base header files and assembly macros Message-ID: <20110218004522.GA27462@gallagher> References: <1297872716-13353-1-git-send-email-john.linn@xilinx.com> <1297872716-13353-2-git-send-email-john.linn@xilinx.com> <1297872716-13353-3-git-send-email-john.linn@xilinx.com> <20110217100126.GD22961@pulham.picochip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1225 Lines: 32 On Thu, Feb 17, 2011 at 05:37:47PM -0700, John Linn wrote: > > > +static inline void arch_reset(char mode, const char *cmd) > > > +{ > > > + /* Add architecture specific reset processing here */ > > > > I think you can add cpu_reset(0) in here to try a soft reset by > jumping > > to the reset vector. This should give you some reset functionality. > > Hi Jamie, > > How strongly do you feel that this has to be in on this initial patch > set? > > There will be many more coming later and I'd like to postpone that one > as it's really additional > functionality vs a bug (to me anyway). I don't have a strong opinion on it. If you leave it as it is so that arch_reset() will return then the generic ARM code will issue a printk to tell the user that it failed then drop into an infinite loop so it should be obvious that reset isn't implemented! If reset is nontrivial then you're probably right to leave it out of this patch and put it into another later on. Jamie -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/