Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754943Ab1BRHIk (ORCPT ); Fri, 18 Feb 2011 02:08:40 -0500 Received: from mail-qw0-f46.google.com ([209.85.216.46]:58187 "EHLO mail-qw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753181Ab1BRHId (ORCPT ); Fri, 18 Feb 2011 02:08:33 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=Kc0OZG7FbeUQ7ixrCifkbJiylajePT2oAPKHV4uP2OGMFa/zH3JwFbbHNpx6KoMu/k BuNqtWNTd1r7NrcQCNmVXr4XRTjx4ErOACji3odfXMVE505IXhHxEgGfIL0DQoRwlFAr isZ2Cr+VffxnTLuizKRE3vYUxIEjY0hkjKsd8= MIME-Version: 1.0 In-Reply-To: <4D5DACC5.60105@tilera.com> References: <4D5DA60A.8080201@tilera.com> <20110217.145333.232751283.davem@davemloft.net> <4D5DA96D.5060200@tilera.com> <20110217.151147.35033921.davem@davemloft.net> <4D5DACC5.60105@tilera.com> Date: Fri, 18 Feb 2011 15:08:31 +0800 Message-ID: Subject: Re: IGMP and rwlock: Dead ocurred again on TILEPro From: Cypher Wu To: Chris Metcalf Cc: David Miller , xiyou.wangcong@gmail.com, linux-kernel@vger.kernel.org, eric.dumazet@gmail.com, netdev@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2230 Lines: 53 On Fri, Feb 18, 2011 at 7:18 AM, Chris Metcalf wrote: > On 2/17/2011 6:11 PM, David Miller wrote: >> From: Chris Metcalf >> Date: Thu, 17 Feb 2011 18:04:13 -0500 >> >>> On 2/17/2011 5:53 PM, David Miller wrote: >>>> From: Chris Metcalf >>>> Date: Thu, 17 Feb 2011 17:49:46 -0500 >>>> >>>>> The fix is to disable interrupts for the arch_read_lock family of methods. >>>> How does that help handle the race when it happens between different >>>> cpus, instead of between IRQ and non-IRQ context on the same CPU? >>> There's no race in that case, since the lock code properly backs off and >>> retries until the other cpu frees it. The distinction here is that the >>> non-IRQ context is "wedged" by the IRQ context. >>> >>>> Why don't you just use the generic spinlock based rwlock code on Tile, >>>> since that is all that your atomic instructions can handle >>>> sufficiently? >>> The tile-specific code encodes reader/writer information in the same 32-bit >>> word that the test-and-set instruction manipulates, so it's more efficient >>> both in space and time. This may not really matter for rwlocks, since no >>> one cares much about them any more, but that was the motivation. >> Ok, but IRQ disabling is going to be very expensive. > > The interrupt architecture on Tile allows a write to a special-purpose > register to put you into a "critical section" where no interrupts or faults > are delivered. So we just need to bracket the read_lock operations with > two SPR writes; each takes six machine cycles, so we're only adding 12 > cycles to the total cost of taking or releasing a read lock on an rwlock. > > -- > Chris Metcalf, Tilera Corp. > http://www.tilera.com > > Adding that to SPR writes should be fine, but it may cause interrupt delay a little more that other platform's read_lock()? Another question: What NMI in the former mail means? Looking forward to your patch. Regards -- Cyberman Wu -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/