Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758157Ab1BRJGm (ORCPT ); Fri, 18 Feb 2011 04:06:42 -0500 Received: from mail-wy0-f174.google.com ([74.125.82.174]:52708 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757956Ab1BRJGb (ORCPT ); Fri, 18 Feb 2011 04:06:31 -0500 Date: Fri, 18 Feb 2011 09:06:25 +0000 From: Jamie Iles To: John Linn Cc: Jamie Iles , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux@arm.linux.org.uk, catalin.marinas@arm.com, glikely@secretlab.ca, arnd@arndb.de Subject: Re: [PATCH V3 3/4] ARM: Xilinx: base header files and assembly macros Message-ID: <20110218090625.GA3203@pulham.picochip.com> References: <1297872716-13353-1-git-send-email-john.linn@xilinx.com> <1297872716-13353-2-git-send-email-john.linn@xilinx.com> <1297872716-13353-3-git-send-email-john.linn@xilinx.com> <20110217100126.GD22961@pulham.picochip.com> <2fdc2d92-486e-4319-866f-3882938363c3@VA3EHSMHS026.ehs.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2fdc2d92-486e-4319-866f-3882938363c3@VA3EHSMHS026.ehs.local> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1028 Lines: 28 On Thu, Feb 17, 2011 at 06:19:09PM -0700, John Linn wrote: > > > +#define PHYS_OFFSET 0x0 > > > > This should be PLAT_PHYS_OFFSET and could do with being surrounded > with > > UL() e.g. > > > > #define PLAT_PHYS_OFFSET UL(0x00000000) > > This doesn't build with 2.6.38-rc5, am I missing something? > > PHYS_OFFSET is still needed from what I can tell, but maybe I overlooked > something. The change is queued up in Russell's devel branch for the dynamic p2v and will be in 2.6.39. For a patch series like this it's probably worth developing off of linux-next[1]. This contains all of the trees that will be mereged into the next kernel so carries the bigger changes like dynamic p2v. Jamie 1. git://git.kernel.org/pub/scm/linux/kernel/git/sfr/linux-next.git -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/