Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758233Ab1BRJM1 (ORCPT ); Fri, 18 Feb 2011 04:12:27 -0500 Received: from mail-gy0-f174.google.com ([209.85.160.174]:38126 "EHLO mail-gy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756736Ab1BRJMR (ORCPT ); Fri, 18 Feb 2011 04:12:17 -0500 Message-ID: From: "Subhasish Ghosh" To: "Marc Kleine-Budde" Cc: "Wolfgang Grandegger" , , , "CAN NETWORK DRIVERS" , , "LKML" , "CAN NETWORK DRIVERS" , , References: <1297435892-28278-1-git-send-email-subhasish@mistralsolutions.com> <1297435892-28278-10-git-send-email-subhasish@mistralsolutions.com> <20110211152026.GC373@e-circ.dyndns.org> <32A5399EB727427C98185089E5DBFA65@subhasishg> <4D5E2570.10108@grandegger.com> <184FA07B783D4F5FAAC09D5C11737A3F@subhasishg> <4D5E2F86.1020400@pengutronix.de> In-Reply-To: <4D5E2F86.1020400@pengutronix.de> Subject: Re: [PATCH v2 09/13] can: pruss CAN driver. Date: Fri, 18 Feb 2011 14:39:15 +0530 Organization: Mistral Solutions MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="iso-8859-1"; reply-type=original Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal Importance: Normal X-Mailer: Microsoft Windows Live Mail 14.0.8117.416 X-MimeOLE: Produced By Microsoft MimeOLE V14.0.8117.416 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1206 Lines: 34 Ok, will do NAPI On 02/18/2011 09:15 AM, Subhasish Ghosh wrote: >> On 02/18/2011 08:07 AM, Subhasish Ghosh wrote: >>> -------------------------------------------------- >>> From: "Kurt Van Dijck" >> >> ... >>>>> + /* register interrupt handler */ >>>>> + err = request_irq(priv->trx_irq, &omapl_rx_can_intr, IRQF_SHARED, >>>>> + "pru_can_irq", ndev); >>>> you're doing a lot of work _in_ the irq handler. Maybe threaded irq? >>>> >>> SG -Ok, will do >> >> No, please use NAPI instead. > > We are using h/w filters, so the number of interrupts coming into the > processor are not hogging it. > I feel that we may not require an interrupt mitigation. As davem stated the other day, all new drivers should use NAPI. regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/