Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754155Ab1BRJjw (ORCPT ); Fri, 18 Feb 2011 04:39:52 -0500 Received: from tx2ehsobe003.messaging.microsoft.com ([65.55.88.13]:34427 "EHLO TX2EHSOBE006.bigfish.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753257Ab1BRJju (ORCPT ); Fri, 18 Feb 2011 04:39:50 -0500 X-SpamScore: -21 X-BigFish: VPS-21(zz1432N98dNzz1202hzz8275bh15d4Rz32i637h668h62h) X-Spam-TCS-SCL: 1:0 X-Forefront-Antispam-Report: KIP:(null);UIP:(null);IPVD:NLI;H:ausb3twp02.amd.com;RD:none;EFVD:NLI X-WSS-ID: 0LGT466-02-507-02 X-M-MSG: Date: Fri, 18 Feb 2011 10:39:57 +0100 From: Borislav Petkov To: Dan Carpenter , Ingo Molnar CC: Andreas Herrmann , Thomas Gleixner , "H. Peter Anvin" , "maintainer:X86 ARCHITECTURE..." , "open list:AMD MICROCODE UPD..." , open list , Subject: Re: [patch -next] x86, microcode, AMD: signedness bug in generic_load_microcode() Message-ID: <20110218093957.GA29723@aftab> References: <20110218091716.GA4384@bicker> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20110218091716.GA4384@bicker> User-Agent: Mutt/1.5.20 (2009-06-14) X-OriginatorOrg: amd.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 960 Lines: 30 On Fri, Feb 18, 2011 at 04:17:16AM -0500, Dan Carpenter wrote: > install_equiv_cpu_table() returns type int. It uses negative error > codes so using an unsigned type breaks the error handling. > > Signed-off-by: Dan Carpenter Yes, my bad, sorry. Acked-by: Borislav Petkov Ingo, this should go ontop of tip/x86/microcode please, for it fixes 10de52d6655e ("x86, microcode, AMD: Simplify install_equiv_cpu_table"). Thanks a bunch. -- Regards/Gruss, Boris. Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach General Managers: Alberto Bozzo, Andrew Bowd Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/