Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753998Ab1BRLCI (ORCPT ); Fri, 18 Feb 2011 06:02:08 -0500 Received: from mail-iw0-f174.google.com ([209.85.214.174]:35868 "EHLO mail-iw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752818Ab1BRLCG convert rfc822-to-8bit (ORCPT ); Fri, 18 Feb 2011 06:02:06 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=eP4iO/dovmyawNq2lR2b789ZYF1YUTvRV51dNQfE8F3bgHBc4dHKxO57JKPPHiSBvC DXjFhvVjrNYs/juEo7NM4/95TI/VuC43HsAs6iNTi/39v4l3ICVD34jGBtw/3MQKO/FQ rHORn9npAbDtNYk46wPedbasoJV0yy+85bR+4= MIME-Version: 1.0 In-Reply-To: References: <442221b243154ef2546cb921d53b774f2c8f5df5.1297940291.git.minchan.kim@gmail.com> <20110218010416.230a65df.kamezawa.hiroyu@jp.fujitsu.com> Date: Fri, 18 Feb 2011 20:02:04 +0900 Message-ID: Subject: Re: [PATCH v5 2/4] memcg: move memcg reclaimable page into tail of inactive list From: Minchan Kim To: Hiroyuki Kamezawa Cc: KAMEZAWA Hiroyuki , Andrew Morton , linux-mm , LKML , Steven Barrett , Ben Gamari , Peter Zijlstra , Rik van Riel , Mel Gorman , KOSAKI Motohiro , Wu Fengguang , Johannes Weiner , Nick Piggin , Andrea Arcangeli , Balbir Singh Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4751 Lines: 125 On Fri, Feb 18, 2011 at 1:16 PM, Hiroyuki Kamezawa wrote: > 2011/2/18 Minchan Kim : >> Hi Kame, >> >> On Fri, Feb 18, 2011 at 1:04 AM, KAMEZAWA Hiroyuki >> wrote: >>> On Fri, 18 Feb 2011 00:08:20 +0900 >>> Minchan Kim wrote: >>> >>>> The rotate_reclaimable_page function moves just written out >>>> pages, which the VM wanted to reclaim, to the end of the >>>> inactive list.  That way the VM will find those pages first >>>> next time it needs to free memory. >>>> This patch apply the rule in memcg. >>>> It can help to prevent unnecessary working page eviction of memcg. >>>> >>>> Acked-by: Balbir Singh >>>> Acked-by: KAMEZAWA Hiroyuki >>>> Reviewed-by: Rik van Riel >>>> Cc: KOSAKI Motohiro >>>> Cc: Johannes Weiner >>>> Signed-off-by: Minchan Kim >>>> --- >>>> Changelog since v4: >>>>  - add acked-by and reviewed-by >>>>  - change description - suggested by Rik >>>> >>>>  include/linux/memcontrol.h |    6 ++++++ >>>>  mm/memcontrol.c            |   27 +++++++++++++++++++++++++++ >>>>  mm/swap.c                  |    3 ++- >>>>  3 files changed, 35 insertions(+), 1 deletions(-) >>>> >>>> diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h >>>> index 3da48ae..5a5ce70 100644 >>>> --- a/include/linux/memcontrol.h >>>> +++ b/include/linux/memcontrol.h >>>> @@ -62,6 +62,7 @@ extern int mem_cgroup_cache_charge(struct page *page, struct mm_struct *mm, >>>>                                       gfp_t gfp_mask); >>>>  extern void mem_cgroup_add_lru_list(struct page *page, enum lru_list lru); >>>>  extern void mem_cgroup_del_lru_list(struct page *page, enum lru_list lru); >>>> +extern void mem_cgroup_rotate_reclaimable_page(struct page *page); >>>>  extern void mem_cgroup_rotate_lru_list(struct page *page, enum lru_list lru); >>>>  extern void mem_cgroup_del_lru(struct page *page); >>>>  extern void mem_cgroup_move_lists(struct page *page, >>>> @@ -215,6 +216,11 @@ static inline void mem_cgroup_del_lru_list(struct page *page, int lru) >>>>       return ; >>>>  } >>>> >>>> +static inline inline void mem_cgroup_rotate_reclaimable_page(struct page *page) >>>> +{ >>>> +     return ; >>>> +} >>>> + >>>>  static inline void mem_cgroup_rotate_lru_list(struct page *page, int lru) >>>>  { >>>>       return ; >>>> diff --git a/mm/memcontrol.c b/mm/memcontrol.c >>>> index 686f1ce..ab8bdff 100644 >>>> --- a/mm/memcontrol.c >>>> +++ b/mm/memcontrol.c >>>> @@ -813,6 +813,33 @@ void mem_cgroup_del_lru(struct page *page) >>>>       mem_cgroup_del_lru_list(page, page_lru(page)); >>>>  } >>>> >>>> +/* >>>> + * Writeback is about to end against a page which has been marked for immediate >>>> + * reclaim.  If it still appears to be reclaimable, move it to the tail of the >>>> + * inactive list. >>>> + */ >>>> +void mem_cgroup_rotate_reclaimable_page(struct page *page) >>>> +{ >>>> +     struct mem_cgroup_per_zone *mz; >>>> +     struct page_cgroup *pc; >>>> +     enum lru_list lru = page_lru_base_type(page); >>>> + >>>> +     if (mem_cgroup_disabled()) >>>> +             return; >>>> + >>>> +     pc = lookup_page_cgroup(page); >>>> +     /* >>>> +      * Used bit is set without atomic ops but after smp_wmb(). >>>> +      * For making pc->mem_cgroup visible, insert smp_rmb() here. >>>> +      */ >>>> +     smp_rmb(); >>>> +     /* unused or root page is not rotated. */ >>>> +     if (!PageCgroupUsed(pc) || mem_cgroup_is_root(pc->mem_cgroup)) >>>> +             return; >>>> +     mz = page_cgroup_zoneinfo(pc->mem_cgroup, page); >>>> +     list_move_tail(&pc->lru, &mz->lists[lru]); >>>> +} >>>> + >>> >>> Hmm, I'm sorry I misunderstand this. IIUC, page_lru_base_type() always returns >>> LRU_INACTIVE_XXX and this function may move page from active LRU to inactive LRU. >>> >>> Then, LRU counters for memcg should be updated. >> >> Goal of mem_cgroup_rotate_reclaimable_page is same with rotate_reclaimable_page. >> It means the page was already in inactive list. >> Look at the check !PageActive(page). > > Hmm, ok. If so, could you change > > page_lru_base_type() -> page_lru() ? > > It's misleading. No problem. Will resend. > > Thanks, > -Kame > -- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/