Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932315Ab1BRQ66 (ORCPT ); Fri, 18 Feb 2011 11:58:58 -0500 Received: from gir.skynet.ie ([193.1.99.77]:50579 "EHLO gir.skynet.ie" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932247Ab1BRQ6z (ORCPT ); Fri, 18 Feb 2011 11:58:55 -0500 Date: Fri, 18 Feb 2011 16:58:27 +0000 From: Mel Gorman To: Minchan Kim Cc: Andrew Morton , linux-mm , LKML , Steven Barrett , Ben Gamari , Peter Zijlstra , Rik van Riel , KOSAKI Motohiro , Wu Fengguang , Johannes Weiner , Nick Piggin , Andrea Arcangeli , Balbir Singh , KAMEZAWA Hiroyuki Subject: Re: [PATCH v5 4/4] add profile information for invalidated page Message-ID: <20110218165827.GB13246@csn.ul.ie> References: <7563767d6b6e841a8ac5f8315ee166e0f039723c.1297940291.git.minchan.kim@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <7563767d6b6e841a8ac5f8315ee166e0f039723c.1297940291.git.minchan.kim@gmail.com> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2820 Lines: 90 On Fri, Feb 18, 2011 at 12:08:22AM +0900, Minchan Kim wrote: > This patch adds profile information about invalidated page reclaim. > It's just for profiling for test so it is never for merging. > > Acked-by: Rik van Riel > Cc: KOSAKI Motohiro > Cc: Wu Fengguang > Cc: Johannes Weiner > Cc: Nick Piggin > Cc: Mel Gorman > Signed-off-by: Minchan Kim > --- > include/linux/vmstat.h | 4 ++-- > mm/swap.c | 3 +++ > mm/vmstat.c | 3 +++ > 3 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/include/linux/vmstat.h b/include/linux/vmstat.h > index 833e676..c38ad95 100644 > --- a/include/linux/vmstat.h > +++ b/include/linux/vmstat.h > @@ -30,8 +30,8 @@ > > enum vm_event_item { PGPGIN, PGPGOUT, PSWPIN, PSWPOUT, > FOR_ALL_ZONES(PGALLOC), > - PGFREE, PGACTIVATE, PGDEACTIVATE, > - PGFAULT, PGMAJFAULT, > + PGFREE, PGACTIVATE, PGDEACTIVATE, PGINVALIDATE, > + PGRECLAIM, PGFAULT, PGMAJFAULT, > FOR_ALL_ZONES(PGREFILL), > FOR_ALL_ZONES(PGSTEAL), > FOR_ALL_ZONES(PGSCAN_KSWAPD), > diff --git a/mm/swap.c b/mm/swap.c > index 0a33714..980c17b 100644 > --- a/mm/swap.c > +++ b/mm/swap.c > @@ -397,6 +397,7 @@ static void lru_deactivate(struct page *page, struct zone *zone) > * is _really_ small and it's non-critical problem. > */ > SetPageReclaim(page); > + __count_vm_event(PGRECLAIM); > } else { > /* > * The page's writeback ends up during pagevec Is this name potentially misleading? Pages that are reclaimed are accounted for with _steal. It's not particularly obvious but that's the name it was given. I'd worry that an administrator that was not aware of *_steal would read pgreclaim as "pages that were reclaimed" when this is not necessarily the case. Is there a better name for this? pginvalidate_deferred or pginvalidate_delayed maybe? > @@ -409,6 +410,8 @@ static void lru_deactivate(struct page *page, struct zone *zone) > > if (active) > __count_vm_event(PGDEACTIVATE); > + > + __count_vm_event(PGINVALIDATE); > update_page_reclaim_stat(zone, page, file, 0); > } > > diff --git a/mm/vmstat.c b/mm/vmstat.c > index 0c3b504..cbe032b 100644 > --- a/mm/vmstat.c > +++ b/mm/vmstat.c > @@ -896,6 +896,9 @@ static const char * const vmstat_text[] = { > "pgactivate", > "pgdeactivate", > > + "pginvalidate", > + "pgreclaim", > + > "pgfault", > "pgmajfault", > > -- > 1.7.1 > -- Mel Gorman SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/