Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932339Ab1BRRB7 (ORCPT ); Fri, 18 Feb 2011 12:01:59 -0500 Received: from mail-gx0-f174.google.com ([209.85.161.174]:58796 "EHLO mail-gx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932234Ab1BRRB4 convert rfc822-to-8bit (ORCPT ); Fri, 18 Feb 2011 12:01:56 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=bAoAq2zKvSN7Yg+CX4gLNmDJValMlgCK+pk5yZEjvjXu7tnLGXjcgh5gGGrTl9XnsN dxcC7At6DbTKK0dnUGbXNFNHE4W+oM5A/3RUgJ7KTIGjnvfArw2nHb1cKvCG4x3BgrJ/ U0CgQQ+4muRe4kHXxDUg63f6lFmtDAbtbzRJA= MIME-Version: 1.0 In-Reply-To: References: Date: Fri, 18 Feb 2011 20:01:55 +0300 Message-ID: Subject: Re: [PATCH 08/20] mfd: ab3100: world-writable debugfs *_priv files From: Vasiliy Kulikov To: linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1723 Lines: 43 2011/2/4 Vasiliy Kulikov : > Don't allow everybody to change device hardware registers. Ping. > Signed-off-by: Vasiliy Kulikov > --- > ?Compile tested only. > > ?drivers/mfd/ab3100-core.c | ? ?4 ++-- > ?1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mfd/ab3100-core.c b/drivers/mfd/ab3100-core.c > index 4193af5..1707d22 100644 > --- a/drivers/mfd/ab3100-core.c > +++ b/drivers/mfd/ab3100-core.c > @@ -613,7 +613,7 @@ static void ab3100_setup_debugfs(struct ab3100 *ab3100) > ? ? ? ?ab3100_get_priv.ab3100 = ab3100; > ? ? ? ?ab3100_get_priv.mode = false; > ? ? ? ?ab3100_get_reg_file = debugfs_create_file("get_reg", > - ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? S_IWUGO, ab3100_dir, &ab3100_get_priv, > + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? S_IWUSR, ab3100_dir, &ab3100_get_priv, > ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?&ab3100_get_set_reg_fops); > ? ? ? ?if (!ab3100_get_reg_file) { > ? ? ? ? ? ? ? ?err = -ENOMEM; > @@ -623,7 +623,7 @@ static void ab3100_setup_debugfs(struct ab3100 *ab3100) > ? ? ? ?ab3100_set_priv.ab3100 = ab3100; > ? ? ? ?ab3100_set_priv.mode = true; > ? ? ? ?ab3100_set_reg_file = debugfs_create_file("set_reg", > - ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? S_IWUGO, ab3100_dir, &ab3100_set_priv, > + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? S_IWUSR, ab3100_dir, &ab3100_set_priv, > ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?&ab3100_get_set_reg_fops); > ? ? ? ?if (!ab3100_set_reg_file) { > ? ? ? ? ? ? ? ?err = -ENOMEM; > -- > 1.7.0.4 > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/