Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756151Ab1BRSYO (ORCPT ); Fri, 18 Feb 2011 13:24:14 -0500 Received: from www.tglx.de ([62.245.132.106]:33646 "EHLO www.tglx.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751813Ab1BRSYN (ORCPT ); Fri, 18 Feb 2011 13:24:13 -0500 Date: Fri, 18 Feb 2011 19:23:49 +0100 (CET) From: Thomas Gleixner To: Alan Cox cc: Subhasish Ghosh , davinci-linux-open-source@linux.davincidsp.com, linux-arm-kernel@lists.infradead.org, m-watkins@ti.com, nsekhar@ti.com, sachi@mistralsolutions.com, Greg Kroah-Hartman , open list Subject: Re: [PATCH v2 13/13] tty: pruss SUART driver In-Reply-To: <20110218143500.23b3044b@lxorguk.ukuu.org.uk> Message-ID: References: <1297435892-28278-1-git-send-email-subhasish@mistralsolutions.com> <1297435892-28278-14-git-send-email-subhasish@mistralsolutions.com> <20110211162814.6ff274f1@lxorguk.ukuu.org.uk> <90BDE50764124CA8AAD560BB1E92C062@subhasishg> <20110218143500.23b3044b@lxorguk.ukuu.org.uk> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1027 Lines: 30 On Fri, 18 Feb 2011, Alan Cox wrote: > On Fri, 18 Feb 2011 19:17:38 +0530 > "Subhasish Ghosh" wrote: > > > Hello, > > > > Regarding the semaphore to mutex migration. > > We are using down_trylock in interrupt context, > > mutex_trylock cannot be used in interrupt context, so we cannot use mutex in > > our driver. > > Then you probably need to rework your locking. Best bet might be to fix > all the other stuff and report the driver, and people can think about the > locking problem. That semaphore is utterly useless to begin with. There are more serious locking problems than this one. Non serialized calls to suart_intr_clrmask/suart_intr_setmask are the most obvious ones. Aside of that the code is complete unreadable. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/