Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758726Ab1BRXil (ORCPT ); Fri, 18 Feb 2011 18:38:41 -0500 Received: from mail-iy0-f174.google.com ([209.85.210.174]:56807 "EHLO mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755590Ab1BRXih convert rfc822-to-8bit (ORCPT ); Fri, 18 Feb 2011 18:38:37 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=A2nhkjgJkBIfa3b6RZ5Vgenh6An0Wv0gMQ4tVxHdynnuStmOqtDMEsEunll3fIzF1X AwDuzhGMS+Zs/c+C77obZYFXlOrnwmxNwTiMba4gtvko/LJhdMYaSAUxhGeHh/YF3GJZ DHYCwbjjkAv1EZtok+xCUmZm5tPvhq7mxoK78= MIME-Version: 1.0 In-Reply-To: <20110218231732.GC13246@csn.ul.ie> References: <7563767d6b6e841a8ac5f8315ee166e0f039723c.1297940291.git.minchan.kim@gmail.com> <20110218165827.GB13246@csn.ul.ie> <20110218231732.GC13246@csn.ul.ie> Date: Sat, 19 Feb 2011 08:38:36 +0900 Message-ID: Subject: Re: [PATCH v5 4/4] add profile information for invalidated page From: Minchan Kim To: Mel Gorman Cc: Andrew Morton , linux-mm , LKML , Steven Barrett , Ben Gamari , Peter Zijlstra , Rik van Riel , KOSAKI Motohiro , Wu Fengguang , Johannes Weiner , Nick Piggin , Andrea Arcangeli , Balbir Singh , KAMEZAWA Hiroyuki Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4193 Lines: 103 On Sat, Feb 19, 2011 at 8:17 AM, Mel Gorman wrote: > On Sat, Feb 19, 2011 at 07:07:01AM +0900, Minchan Kim wrote: >> Hi Mel, >> >> On Sat, Feb 19, 2011 at 1:58 AM, Mel Gorman wrote: >> > On Fri, Feb 18, 2011 at 12:08:22AM +0900, Minchan Kim wrote: >> >> This patch adds profile information about invalidated page reclaim. >> >> It's just for profiling for test so it is never for merging. >> >> >> >> Acked-by: Rik van Riel >> >> Cc: KOSAKI Motohiro >> >> Cc: Wu Fengguang >> >> Cc: Johannes Weiner >> >> Cc: Nick Piggin >> >> Cc: Mel Gorman >> >> Signed-off-by: Minchan Kim >> >> --- >> >>  include/linux/vmstat.h |    4 ++-- >> >>  mm/swap.c              |    3 +++ >> >>  mm/vmstat.c            |    3 +++ >> >>  3 files changed, 8 insertions(+), 2 deletions(-) >> >> >> >> diff --git a/include/linux/vmstat.h b/include/linux/vmstat.h >> >> index 833e676..c38ad95 100644 >> >> --- a/include/linux/vmstat.h >> >> +++ b/include/linux/vmstat.h >> >> @@ -30,8 +30,8 @@ >> >> >> >>  enum vm_event_item { PGPGIN, PGPGOUT, PSWPIN, PSWPOUT, >> >>               FOR_ALL_ZONES(PGALLOC), >> >> -             PGFREE, PGACTIVATE, PGDEACTIVATE, >> >> -             PGFAULT, PGMAJFAULT, >> >> +             PGFREE, PGACTIVATE, PGDEACTIVATE, PGINVALIDATE, >> >> +             PGRECLAIM, PGFAULT, PGMAJFAULT, >> >>               FOR_ALL_ZONES(PGREFILL), >> >>               FOR_ALL_ZONES(PGSTEAL), >> >>               FOR_ALL_ZONES(PGSCAN_KSWAPD), >> >> diff --git a/mm/swap.c b/mm/swap.c >> >> index 0a33714..980c17b 100644 >> >> --- a/mm/swap.c >> >> +++ b/mm/swap.c >> >> @@ -397,6 +397,7 @@ static void lru_deactivate(struct page *page, struct zone *zone) >> >>                * is _really_ small and  it's non-critical problem. >> >>                */ >> >>               SetPageReclaim(page); >> >> +             __count_vm_event(PGRECLAIM); >> >>       } else { >> >>               /* >> >>                * The page's writeback ends up during pagevec >> > >> > Is this name potentially misleading? >> > >> > Pages that are reclaimed are accounted for with _steal. It's not particularly >> > obvious but that's the name it was given. I'd worry that an administrator that >> > was not aware of *_steal would read pgreclaim as "pages that were reclaimed" >> > when this is not necessarily the case. >> > >> > Is there a better name for this? pginvalidate_deferred >> > or pginvalidate_delayed maybe? >> > >> >> Yep. Your suggestion is fair enough. But as I said in description, >> It's just for testing for my profiling, not merging so I didn't care >> about it. I don't think we need new vmstat of pginvalidate. >> > > My bad. I was treating this piece of information as something we'd keep > around and did not read the introduction clearly enough. If it's just for > evaluation, the name does not matter as long as the reviewers know what it > is. The figures look good and I have no problem with the series. I didn't > ack the memcg parts but only because memcg is not an area I'm familiar enough > for my ack to proper meaning. If there are no other objections, I'd suggest > resubmitting minus this patch. Okay. I will wait any comments from others by this week and resubmit the series at next week as remove profiling patch. Thanks, Mel. > > Thanks. > > -- > Mel Gorman > SUSE Labs > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org.  For more info on Linux MM, > see: http://www.linux-mm.org/ . > Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ > Don't email: email@kvack.org > -- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/