Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755186Ab1BULFy (ORCPT ); Mon, 21 Feb 2011 06:05:54 -0500 Received: from mail-yx0-f174.google.com ([209.85.213.174]:62392 "EHLO mail-yx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750840Ab1BULFw convert rfc822-to-8bit (ORCPT ); Mon, 21 Feb 2011 06:05:52 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=e1bIxymod/dGf8JM8AjXRjWyOrq5atukozFvLBARsRmDpV5E3p7UNVKFLNa8VnoX0u SM9JPQC/Zopm0Sj+L9qHmzsnFnCQTFig4Nm2W62Bn4uOxwRFfqBW/rV1z/kUr5OqZXIx Gdjro5lXnsnR3K11ohjmE8LPu6t/Y+DI/pPGs= MIME-Version: 1.0 In-Reply-To: <1298283649-24532-2-git-send-email-dacohen@gmail.com> References: <1298283649-24532-1-git-send-email-dacohen@gmail.com> <1298283649-24532-2-git-send-email-dacohen@gmail.com> Date: Mon, 21 Feb 2011 13:05:51 +0200 Message-ID: Subject: Re: [PATCH 1/1] headers: fix circular dependency between linux/sched.h and linux/wait.h From: Alexey Dobriyan To: David Cohen Cc: linux-kernel@vger.kernel.org, mingo@elte.hu, peterz@infradead.org, linux-omap@vger.kernel.org, linux-media@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1505 Lines: 31 On Mon, Feb 21, 2011 at 12:20 PM, David Cohen wrote: > Currently sched.h and wait.h have circular dependency between both. > wait.h defines macros wake_up*() which use macros TASK_* defined by > sched.h. But as sched.h indirectly includes wait.h, such wait.h header > file can't include sched.h too. The side effect is when some file > includes wait.h and tries to use its wake_up*() macros, it's necessary > to include sched.h also. > This patch moves all TASK_* macros from linux/sched.h to a new header > file linux/task_sched.h. This way, both sched.h and wait.h can include > task_sched.h and fix the circular dependency. No need to include sched.h > anymore when wake_up*() macros are used. Just include in your driver. This include splitting in small pieces is troublesome as well. Why are you moving TASK_COMM_LEN? > ?include/linux/sched.h ? ? ?| ? 61 +----------------------------------------- > ?include/linux/task_sched.h | ? 64 ++++++++++++++++++++++++++++++++++++++++++++ > ?include/linux/wait.h ? ? ? | ? ?1 + > ?3 files changed, 66 insertions(+), 60 deletions(-) > ?create mode 100644 include/linux/task_sched.h > --- a/include/linux/sched.h > +++ b/include/linux/sched.h > +#include -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/