Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754286Ab1BUTVg (ORCPT ); Mon, 21 Feb 2011 14:21:36 -0500 Received: from mail-fx0-f46.google.com ([209.85.161.46]:38576 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753941Ab1BUTVb (ORCPT ); Mon, 21 Feb 2011 14:21:31 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=lzPlWNtBhE6vSkILhmyooQ5qv7ezbW/N6neKQsaGFbOm3GPw5iRfBiH1gqCpQEU5nS jrEI4CmHVvbFcCY/FVlhnnBLEM53CYoFLSaeom3TaIrZnOI7Zgkm2C1yXvGEqNr6Oc8N Os0GuKit7H+yK2hoNe7BU3+GXHne7TOZcYPLo= Date: Mon, 21 Feb 2011 21:21:20 +0200 From: Alexey Dobriyan To: Peter Zijlstra Cc: balbi@ti.com, David Cohen , linux-kernel@vger.kernel.org, mingo@elte.hu, linux-omap@vger.kernel.org, linux-media@vger.kernel.org, Oleg Nesterov Subject: Re: [PATCH v2 1/1] headers: fix circular dependency between linux/sched.h and linux/wait.h Message-ID: <20110221192046.GA6822@p183.telecom.by> References: <1298299131-17695-1-git-send-email-dacohen@gmail.com> <1298299131-17695-2-git-send-email-dacohen@gmail.com> <1298303677.24121.1.camel@twins> <1298305245.24121.7.camel@twins> <20110221162939.GK23087@legolas.emea.dhcp.ti.com> <1298306607.24121.18.camel@twins> <20110221165443.GL23087@legolas.emea.dhcp.ti.com> <1298307962.24121.27.camel@twins> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1298307962.24121.27.camel@twins> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 858 Lines: 26 On Mon, Feb 21, 2011 at 06:06:02PM +0100, Peter Zijlstra wrote: > 1) remove the inclusion of completion.h -- easy we can live with an > incomplete type. ACK > 2) move the other wait_queue_head_t users (signal_struct sighand_struct) > out of sched.h > > 3) ... Compile test! :^) > 4) profit! > > Just isolating the TASK_state bits isn't going to be enough, wait.h also > wants wake_up goo and schedule*(), therefore either include sched.h from > whatever .c file you're using wait.h bits or do the above cleanup. Speaking of junk in sched.h, I'll send mm_types.h removal next merge window and maybe cred.h. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/