Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752445Ab1BVAcG (ORCPT ); Mon, 21 Feb 2011 19:32:06 -0500 Received: from TYO202.gate.nec.co.jp ([202.32.8.206]:47194 "EHLO tyo202.gate.nec.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751104Ab1BVAcF (ORCPT ); Mon, 21 Feb 2011 19:32:05 -0500 Date: Tue, 22 Feb 2011 09:30:22 +0900 From: Naoya Horiguchi To: Petr Holasek Cc: linux-kernel@vger.kernel.org, Andi Kleen , Mel Gorman , Andrew Morton , Wu Fengguang , linux-mm@kvack.org Subject: Re: [PATCH] hugetlbfs: correct handling of negative input to /proc/sys/vm/nr_hugepages Message-ID: <20110222003022.GA2895@spritzera.linux.bs1.fc.nec.co.jp> References: <1298303270-3184-1-git-send-email-pholasek@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-2022-jp Content-Disposition: inline In-Reply-To: <1298303270-3184-1-git-send-email-pholasek@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1237 Lines: 34 On Mon, Feb 21, 2011 at 04:47:49PM +0100, Petr Holasek wrote: > When user insert negative value into /proc/sys/vm/nr_hugepages it will result > in the setting a random number of HugePages in system (can be easily showed > at /proc/meminfo output). This patch fixes the wrong behavior so that the > negative input will result in nr_hugepages value unchanged. > > Signed-off-by: Petr Holasek > --- > mm/hugetlb.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index bb0b7c1..f99d7a8 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -1872,8 +1872,7 @@ static int hugetlb_sysctl_handler_common(bool obey_mempolicy, > unsigned long tmp; > int ret; > > - if (!write) > - tmp = h->max_huge_pages; > + tmp = h->max_huge_pages; Looks reasonable. hugetlb_overcommit_handler() has the same wrong behavior. So how about fixing that too? Anyway, Reviewed-by: Naoya Horiguchi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/