Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754034Ab1BVLNB (ORCPT ); Tue, 22 Feb 2011 06:13:01 -0500 Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:59721 "EHLO www.etchedpixels.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752260Ab1BVLNA (ORCPT ); Tue, 22 Feb 2011 06:13:00 -0500 Date: Tue, 22 Feb 2011 11:14:00 +0000 From: Alan Cox To: Bartlomiej Zolnierkiewicz Cc: Jeff Garzik , Sergei Shtylyov , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 05/20] pata_efar: always program master_data before slave_data Message-ID: <20110222111400.1114e8c5@lxorguk.ukuu.org.uk> In-Reply-To: References: <20110208122314.19110.4092.sendpatchset@linux-mhg7.site> <20110208122409.19110.4233.sendpatchset@linux-mhg7.site> <20110208130701.19709cc6@lxorguk.ukuu.org.uk> <20110208132518.300bb098@lxorguk.ukuu.org.uk> <4D514754.30203@ru.mvista.com> <4D62C5E1.9070307@pobox.com> X-Mailer: Claws Mail 3.7.8 (GTK+ 2.22.0; x86_64-redhat-linux-gnu) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEWysKsSBQMIAwIZCwj///8wIhxoRDXH9QHCAAABeUlEQVQ4jaXTvW7DIBAAYCQTzz2hdq+rdg494ZmBeE5KYHZjm/d/hJ6NfzBJpp5kRb5PHJwvMPMk2L9As5Y9AmYRBL+HAyJKeOU5aHRhsAAvORQ+UEgAvgddj/lwAXndw2laEDqA4x6KEBhjYRCg9tBFCOuJFxg2OKegbWjbsRTk8PPhKPD7HcRxB7cqhgBRp9Dcqs+B8v4CQvFdqeot3Kov6hBUn0AJitrzY+sgUuiA8i0r7+B3AfqKcN6t8M6HtqQ+AOoELCikgQSbgabKaJW3kn5lBs47JSGDhhLKDUh1UMipwwinMYPTBuIBjEclSaGZUk9hDlTb5sUTYN2SFFQuPe4Gox1X0FZOufjgBiV1Vls7b+GvK3SU4wfmcGo9rPPQzgIabfj4TYQo15k3bTHX9RIw/kniir5YbtJF4jkFG+dsDK1IgE413zAthU/vR2HVMmFUPIHTvF6jWCpFaGw/A3qWgnbxpSm9MSmY5b3pM1gvNc/gQfwBsGwF0VCtxZgAAAAASUVORK5CYII= Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 936 Lines: 20 > I was thinking about re-doing ata_piix part in a way that we could > merge it now by adding support for older PIIX-alikes to ata_piix and > making it enabled only if "all_piixalikes" module parameter is > specified. This way older drivers would be left untouched for now > and we can easily get in-tree testing for a new code. Does it sound > as a viable alternative? That is the bit to me that makes the least sense. Each of the devices in question is found only in the chipset so they can never be in combination on a board (except multiple PIIX4 which is already covered) Merging them makes it more likely stuff breaks and increases memory usage - its a lose/lose situation. Alan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/