Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754201Ab1BVMGv (ORCPT ); Tue, 22 Feb 2011 07:06:51 -0500 Received: from bear.ext.ti.com ([192.94.94.41]:50735 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754050Ab1BVMGu convert rfc822-to-8bit (ORCPT ); Tue, 22 Feb 2011 07:06:50 -0500 From: "TK, Pratheesh Gangadhar" To: Sergei Shtylyov , "Hans J. Koch" CC: "davinci-linux-open-source@linux.davincidsp.com" , Arnd Bergmann , "Chatterjee, Amit" , "gregkh@suse.de" , LKML , Thomas Gleixner , "linux-arm-kernel@lists.infradead.org" Date: Tue, 22 Feb 2011 17:36:23 +0530 Subject: RE: [PATCH 1/2] PRUSS UIO driver support Thread-Topic: [PATCH 1/2] PRUSS UIO driver support Thread-Index: AcvSASxgVASxUIvaQfi0Cwydute6ngAhxfyA Message-ID: References: <1298041530-26855-1-git-send-email-pratheesh@ti.com> <201102181644.17634.arnd@arndb.de> <201102181731.05644.arnd@arndb.de> <20110219183427.GG4684@local> <20110221193316.GC2773@local> <4D62C2A0.6060405@mvista.com> In-Reply-To: <4D62C2A0.6060405@mvista.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2404 Lines: 69 Hi, > -----Original Message----- > From: Sergei Shtylyov [mailto:sshtylyov@mvista.com] > Sent: Tuesday, February 22, 2011 1:23 AM > To: Hans J. Koch > Cc: TK, Pratheesh Gangadhar; davinci-linux-open- > source@linux.davincidsp.com; Arnd Bergmann; Chatterjee, Amit; > gregkh@suse.de; LKML; Thomas Gleixner; linux-arm- > kernel@lists.infradead.org > Subject: Re: [PATCH 1/2] PRUSS UIO driver support > > Hello. > > Hans J. Koch wrote: > > >>> -----Original Message----- > >>> From: Hans J. Koch [mailto:hjk@hansjkoch.de] > >>> Sent: Sunday, February 20, 2011 12:04 AM > >>> To: TK, Pratheesh Gangadhar > >>> Cc: Thomas Gleixner; Arnd Bergmann; linux-arm- > kernel@lists.infradead.org; > >>> davinci-linux-open-source@linux.davincidsp.com; gregkh@suse.de; > >>> Chatterjee, Amit; Hans J. Koch; LKML > >>> Subject: Re: [PATCH 1/2] PRUSS UIO driver support > > >>> On Sat, Feb 19, 2011 at 09:10:23PM +0530, TK, Pratheesh Gangadhar > wrote: > >>>> For my understanding - if the interrupt is not shared and not level > triggered - > >>>> is this okay to have empty handler? > > >>> Greg already said he won't accept that. And I'm quite sure these > >>> interrupts > >>> are level triggered, since that is the default on arch/omap. > > >>> E.g. in arch/arm/mach-omap1/irq.c, a loop sets all irqs to level > triggered > >>> handling: set_irq_handler(j, handle_level_irq); (line 234) > > >> You should be looking at arch/arm/mach-davinci/irq.c > > Into arch/arm/mach-davinci/cp_intc.c actually as we're not talking > about a > "real" DaVincis here, but about OMAP-L138. > > > Hmpf. I alway get lost in the directory structure of TI SoCs... > > At least I learned that OMAP3 is in the omap2 directory :) > > It's probably even more convoluted with DaVinci and friends. :-) > > >> and all interrupts except IRQ_TINT1_TINT34 is set to edge trigger mode > (line 160). > > > Is that really needed? Level triggered interrupts should certainly be > > preferred if possible. > > Don't look there, this code is for "real" DaVincis only. > Thanks for correcting. Interrupts are configured as edge triggered here as well. Thanks and Regards, Pratheesh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/