Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751291Ab1BVMY4 (ORCPT ); Tue, 22 Feb 2011 07:24:56 -0500 Received: from mailout-de.gmx.net ([213.165.64.22]:49156 "HELO mailout-de.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1750736Ab1BVMYz (ORCPT ); Tue, 22 Feb 2011 07:24:55 -0500 X-Authenticated: #911537 X-Provags-ID: V01U2FsdGVkX1/iPIVwA83iGL5yBlzI9o5Aet+wC7to/VLsjKCJ5b 2dXofjDzekWqjy Date: Tue, 22 Feb 2011 13:24:49 +0100 From: torbenh To: Mike Galbraith Cc: Peter Zijlstra , Yong Zhang , bharata@linux.vnet.ibm.com, Ingo Molnar , linux-kernel@vger.kernel.org, tglx@linutronix.de Subject: Re: [patch] Re: autogroup: sched_setscheduler() fails Message-ID: <20110222122449.GC11548@siel.b> Mail-Followup-To: Mike Galbraith , Peter Zijlstra , Yong Zhang , bharata@linux.vnet.ibm.com, Ingo Molnar , linux-kernel@vger.kernel.org, tglx@linutronix.de References: <20110111171046.GL4772@in.ibm.com> <1294771686.8006.15.camel@marge.simson.net> <1294810842.8370.7.camel@marge.simson.net> <1294890890.8089.39.camel@marge.simson.net> <1295270160.30950.96.camel@laptop> <20110215154612.GI3055@siel.b> <1297788210.15382.51.camel@marge.simson.net> <20110218110955.GA3124@siel.b> <1298033412.8735.30.camel@marge.simson.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1298033412.8735.30.camel@marge.simson.net> User-Agent: Mutt/1.5.20 (2009-06-14) X-Y-GMX-Trusted: 0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2898 Lines: 71 On Fri, Feb 18, 2011 at 01:50:12PM +0100, Mike Galbraith wrote: > On Fri, 2011-02-18 at 12:09 +0100, torbenh wrote: > > On Tue, Feb 15, 2011 at 05:43:30PM +0100, Mike Galbraith wrote: > > > On Tue, 2011-02-15 at 16:46 +0100, torbenh wrote: > > > > On Mon, Jan 17, 2011 at 02:16:00PM +0100, Peter Zijlstra wrote: > > > > > On Thu, 2011-01-13 at 04:54 +0100, Mike Galbraith wrote: > > > > > > sched, autogroup: fix CONFIG_RT_GROUP_SCHED sched_setscheduler() failure. > > > > > > > > > > > > If CONFIG_RT_GROUP_SCHED is set, __sched_setscheduler() fails due to autogroup > > > > > > not allocating rt_runtime. Free unused/unusable rt_se and rt_rq, redirect RT > > > > > > tasks to the root task group, and tell __sched_setscheduler() that it's ok. > > > > > > > > > > > > Signed-off-by: Mike Galbraith > > > > > > Reported-by: Bharata B Rao > > > > > > > > > > Thanks, applied! > > > > > > > > while this behaviour is certeinly necessary, i think this is a hack. > > > > it fixes the problem for autogroups. > > > > But its not fixed for things which want to control the cfs shares via > > > > normal cgroups. > > > > > > You mean automated control ala systemd? For a static set of groups, it > > > works fine. I was wondering how systemd would deal with it. > > > > but i can not get the same behaviour as if CONFIG_RT_GROUP_SCHED was > > off. iE N cgroups with different cpu.share values, but each with > > rt_runtime_us=950000 > > ? if CONFIG_RT_GROUP_SCHED was a noop, it wouldn't exist. > > > if the rt_runtime_us was in a different subsystem, its my understanding > > that i could leave rt_runtime_us alone, and have all tasks in the root > > group in the rt_runtime subsystem. > > Sounds like you just want to turn CONFIG_RT_GROUP_SCHED off. but distros turn it on. we could prevent debian from turning it on. now opensuse 11.4 has turned it on. > > > > The allocation problem was shamelessly punted back to the user, where I > > > think it truly belongs. > > > > sure it belongs to the user. but what if user wants to have different > > cpu.shares, but full rt_runtime_us for all tasks ? > > Then the user doesn't want CONFIG_RT_GROUP_SCHED set. but distros force it onto the user. if systemd shows up, and puts things into different cgroups, we end up with a pretty fragmented rt_runtime_us. > > -Mike > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- torben Hohn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/