DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=date:from:to:cc:subject:message-id:mail-followup-to:references
         :mime-version:content-type:content-disposition:in-reply-to
         :user-agent;
        b=oHxMMqR/kAHiq/BA7bez8Ju5bQwiIS7F5KPutYEl5JC7IU4Qv2FveTMW3X+SWjTBMH
         9RJUk4cJUhHPpiZQhGbz0cVCf6itjdq8G45dpLGWU2VHJS92ZPXX8+cohiROYh3+OtGP
         hZGVFLF20vVy6z1RDXXWHBQRdrJmexgXz0aBI=
Date: Tue, 22 Feb 2011 15:36:01 +0300
From: Dan Carpenter <error27@gmail.com>
To: Dirk Eibach <eibach@gdsys.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpio: Fix wrong pointer type in pca953x
Message-ID: <20110222123601.GA1966@bicker>
Mail-Followup-To: Dan Carpenter <error27@gmail.com>,
	Dirk Eibach <eibach@gdsys.de>, linux-kernel@vger.kernel.org
References: <1298365010-22951-1-git-send-email-eibach@gdsys.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1298365010-22951-1-git-send-email-eibach@gdsys.de>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 671
Lines: 20

On Tue, Feb 22, 2011 at 09:56:50AM +0100, Dirk Eibach wrote:
>  	struct pca953x_platform_data *pdata;
>  	struct device_node *node;
> -	const uint16_t *val;
> +	const u32 *val;
>  

This should probably be signed?  We compare it against zero later on.

                if (*val < 0)
                        dev_warn(&client->dev,
                                 "invalid gpio-base in device tree\n");

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/