Message-ID: <4D63C1B2.1050507@cam.ac.uk>
Date: Tue, 22 Feb 2011 14:01:22 +0000
From: Jonathan Cameron <jic23@cam.ac.uk>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20110122 Lightning/1.0b3pre Thunderbird/3.1.7
MIME-Version: 1.0
To: "Cai, Cliff" <Cliff.Cai@analog.com>
CC: Michael Hennerich <michael.hennerich@analog.com>,
        "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Drivers <Drivers@analog.com>,
        "device-drivers-devel@blackfin.uclinux.org" 
	<device-drivers-devel@blackfin.uclinux.org>
Subject: Re: [Device-drivers-devel] [PATCH] IIO driver for Analog Devices
 Digital Output Gyroscope ADXRS450
References: <1297676849-28704-1-git-send-email-test@ten.analog.com> <4D5914A8.9030809@analog.com>
In-Reply-To: <4D5914A8.9030809@analog.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 930
Lines: 22

On 02/14/11 11:40, Michael Hennerich wrote:
> Hi Cliff,
> 
> Exposing every single register to user space is not an acceptable driver.
> Ideally a user of this driver doesn't need to read the datasheet, only
> the IIO ABI Documentation.
> This driver can also benefit from triggered sampling/ring buffer support.
At some point.... I wouldn't necessarily advocate this for an initial merge. doing
it in two steps can make for bite sized reviews which definitely have their
advantages!

Given Michael has done a thorough review (thanks) I'll leave looking at this until
you've addressed his comments.  Please be careful to avoid dead email addresses (test@analog.com)

Thanks,

Jonathan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/