From: Arnd Bergmann <arnd@arndb.de>
To: "Guan Xuetao" <gxt@mprc.pku.edu.cn>
Subject: Re: [PATCH 11/12] unicore32 machine related files: ps2 driver
Date: Tue, 22 Feb 2011 18:11:58 +0100
User-Agent: KMail/1.12.2 (Linux/2.6.31-22-generic; KDE/4.3.2; x86_64; ; )
Cc: dmitry.torokhov@gmail.com, linux-kernel@vger.kernel.org,
        linux-arch@vger.kernel.org, "'Greg KH'" <greg@kroah.com>
References: <015701cbcdae$7d5f43f0$781dcbd0$@mprc.pku.edu.cn> <201102181133.26675.arnd@arndb.de> <019001cbd29c$7cee6340$76cb29c0$@mprc.pku.edu.cn>
In-Reply-To: <019001cbd29c$7cee6340$76cb29c0$@mprc.pku.edu.cn>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201102221811.58441.arnd@arndb.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1141
Lines: 28

On Tuesday 22 February 2011, Guan Xuetao wrote:
> diff --git a/drivers/input/serio/i8042-unicore32io.h b/drivers/input/serio/i8042-unicore32io.h
> index 2cdd872..9350843 100644
> --- a/drivers/input/serio/i8042-unicore32io.h
> +++ b/drivers/input/serio/i8042-unicore32io.h
> @@ -29,11 +29,11 @@
>  /*
>   * Register numbers.
>   */
> -#define I8042_COMMAND_REG      ((volatile void __iomem *)&PS2_COMMAND)
> -#define I8042_STATUS_REG       ((volatile void __iomem *)&PS2_STATUS)
> -#define I8042_DATA_REG         ((volatile void __iomem *)&PS2_DATA)
> +#define I8042_COMMAND_REG      PS2_COMMAND
> +#define I8042_STATUS_REG       PS2_STATUS
> +#define I8042_DATA_REG         PS2_DATA

I wouldn't bother defining two sets of macros then. Either use PS2_COMMAND
in the driver, or define I8042_COMMAND_REG in the place where you currently
define PS2_COMMAND.

Aside from this, it looks good.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/