Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754994Ab1BVSL3 (ORCPT ); Tue, 22 Feb 2011 13:11:29 -0500 Received: from smtp.outflux.net ([198.145.64.163]:47907 "EHLO smtp.outflux.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754952Ab1BVSL2 (ORCPT ); Tue, 22 Feb 2011 13:11:28 -0500 From: Kees Cook To: linux-kernel@vger.kernel.org Cc: Eugene Teo , Ralph Campbell , Roland Dreier , Sean Hefty , Hal Rosenstock , Jeremy Fitzhardinge , Konrad Rzeszutek Wilk , Alexander Viro , Greg Kroah-Hartman , Miklos Szeredi , "J. Bruce Fields" , Neil Brown , Matthew Wilcox , James Morris , Stephen Smalley , Eric Paris , Nick Piggin , Arnd Bergmann , Ian Campbell , Jarkko Sakkinen , Tejun Heo , Casey Schaufler Subject: [PATCH 2/2] debugfs: only allow root access to debugging interfaces Date: Tue, 22 Feb 2011 10:09:58 -0800 Message-Id: <1298398198-18482-2-git-send-email-kees.cook@canonical.com> X-Mailer: git-send-email 1.7.2.3 In-Reply-To: <1298398198-18482-1-git-send-email-kees.cook@canonical.com> References: <1298398198-18482-1-git-send-email-kees.cook@canonical.com> X-HELO: www.outflux.net Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 952 Lines: 29 Block access to the potentially dangerous debugging interfaces in the debugfs filesystem. Signed-off-by: Kees Cook --- fs/debugfs/inode.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c index 3cb33c3..83c61a3 100644 --- a/fs/debugfs/inode.c +++ b/fs/debugfs/inode.c @@ -133,7 +133,7 @@ static int debug_fill_super(struct super_block *sb, void *data, int silent) static struct tree_descr debug_files[] = {{""}}; return simple_fill_super(sb, DEBUGFS_MAGIC, debug_files, - S_IWUSR | S_IRUGO | S_IXUGO); + S_IRWXU); } static struct dentry *debug_mount(struct file_system_type *fs_type, -- 1.7.2.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/