Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755290Ab1BVTzR (ORCPT ); Tue, 22 Feb 2011 14:55:17 -0500 Received: from smtp.outflux.net ([198.145.64.163]:59406 "EHLO smtp.outflux.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751613Ab1BVTzP (ORCPT ); Tue, 22 Feb 2011 14:55:15 -0500 Date: Tue, 22 Feb 2011 11:54:32 -0800 From: Kees Cook To: Alan Cox Cc: Greg KH , David Daney , linux-kernel@vger.kernel.org, Eugene Teo , Ralph Campbell , Roland Dreier , Sean Hefty , Hal Rosenstock , Jeremy Fitzhardinge , Konrad Rzeszutek Wilk , Alexander Viro , Miklos Szeredi , "J. Bruce Fields" , Neil Brown , Matthew Wilcox , James Morris , Stephen Smalley , Eric Paris , Nick Piggin , Arnd Bergmann , Ian Campbell , Jarkko Sakkinen , Tejun Heo , Casey Schaufler Subject: Re: [PATCH 2/2] debugfs: only allow root access to debugging interfaces Message-ID: <20110222195432.GB4000@outflux.net> References: <1298398198-18482-1-git-send-email-kees.cook@canonical.com> <1298398198-18482-2-git-send-email-kees.cook@canonical.com> <20110222181613.GU4000@outflux.net> <4D640133.9020901@caviumnetworks.com> <20110222184726.GV4000@outflux.net> <20110222191454.GB9991@suse.de> <20110222192532.GY4000@outflux.net> <20110222193418.773ccd4b@lxorguk.ukuu.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110222193418.773ccd4b@lxorguk.ukuu.org.uk> Organization: Canonical X-HELO: www.outflux.net Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 831 Lines: 20 On Tue, Feb 22, 2011 at 07:34:18PM +0000, Alan Cox wrote: > Anyway - we don't mostly have a "root/non-root" model - it went out > around Linux 1.2. So any model for dealing with should be respecting of > capabilities, SELinux and the like. That reminds me; in this line of reasoning, would a patchset to update all the /proc/sys, /sys, etc writing functions to take capability lists and check them be accepted? Because right now, almost everything in /proc/sys uses DAC instead of checking caps. I think the same is true of /sys and debugfs. -Kees -- Kees Cook Ubuntu Security Team -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/