Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752472Ab1BVUc5 (ORCPT ); Tue, 22 Feb 2011 15:32:57 -0500 Received: from smtp-out.google.com ([74.125.121.67]:8129 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751726Ab1BVUcz (ORCPT ); Tue, 22 Feb 2011 15:32:55 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=google.com; s=beta; h=date:from:x-x-sender:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version:content-type; b=s/8b9pn2ORqIB1XTzYe2Q3SmYoVcvmzv3XB3X7pKUi7VUDEcE6ElUH2TQIpdOxIqKQ g1SII2keEuz5gx5KHxSg== Date: Tue, 22 Feb 2011 12:32:49 -0800 (PST) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Petr Holasek cc: linux-kernel@vger.kernel.org, Andi Kleen , Naoya Horiguchi , Mel Gorman , Andrew Morton , Wu Fengguang , linux-mm@kvack.org Subject: Re: [PATCH v2] hugetlbfs: correct handling of negative input to /proc/sys/vm/nr_hugepages In-Reply-To: <4D6419C0.8080804@redhat.com> Message-ID: References: <4D6419C0.8080804@redhat.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 849 Lines: 19 On Tue, 22 Feb 2011, Petr Holasek wrote: > When user insert negative value into /proc/sys/vm/nr_hugepages it will result > in the setting a random number of HugePages in system (can be easily showed > at /proc/meminfo output). This patch fixes the wrong behavior so that the > negative input will result in nr_hugepages value unchanged. > > v2: same fix was also done in hugetlb_overcommit_handler function > as suggested by reviewers. > > Signed-off-by: Petr Holasek > Reviewed-by: Naoya Horiguchi Acked-by: David Rientjes -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/