Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752656Ab1BWKOB (ORCPT ); Wed, 23 Feb 2011 05:14:01 -0500 Received: from e23smtp05.au.ibm.com ([202.81.31.147]:33625 "EHLO e23smtp05.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752141Ab1BWKN7 (ORCPT ); Wed, 23 Feb 2011 05:13:59 -0500 Date: Wed, 23 Feb 2011 15:43:49 +0530 From: Balbir Singh To: Paul Turner Cc: Bharata B Rao , linux-kernel@vger.kernel.org, Dhaval Giani , Vaidyanathan Srinivasan , Gautham R Shenoy , Srivatsa Vaddagiri , Kamalesh Babulal , Ingo Molnar , Peter Zijlstra , Pavel Emelyanov , Herbert Poetzl , Avi Kivity , Chris Friesen , Nikhil Rao Subject: Re: [CFS Bandwidth Control v4 5/7] sched: add exports tracking cfs bandwidth control statistics Message-ID: <20110223101349.GL3379@balbir.in.ibm.com> Reply-To: balbir@linux.vnet.ibm.com References: <20110216031831.571628191@google.com> <20110216031841.258879435@google.com> <20110222031420.GI10342@balbir.in.ibm.com> <20110222041332.GA2753@in.ibm.com> <20110222044035.GL10342@balbir.in.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1544 Lines: 38 * Paul Turner [2011-02-23 00:03:42]: > On Mon, Feb 21, 2011 at 8:40 PM, Balbir Singh wrote: > > * Bharata B Rao [2011-02-22 09:43:33]: > > > >> > > >> > Should we consider integrating this in cpuacct, it would be difficult > >> > if we spill over stats between controllers. > >> > >> Given that cpuacct controller can be mounted independently, I am not sure > >> if we should integrate these stats. These stats come from cpu controller. > > > > The accounting controller was created to account. I'd still prefer > > cpuacct, so that I can find everything in one place. NOTE: cpuacct was > > created so that we do accounting with control - just account. I think > > splitting stats creates a usability mess - no? > > > > One problem with rolling it into cpuacct is that some of the > statistics have a 1:1 association with the hierarchy being throttled. > For example, the number of periods in which throttling occurred or the > count of elapsed periods. > > If it were rolled into cpuacct the only meaningful export would be the > total throttled time -- perhaps this is sufficient? > Good point, lets keep it as is. nr_throttled and nr_periods is also important (although it can be derived). -- Three Cheers, Balbir -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/