DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=date:from:to:cc:subject:message-id:mail-followup-to:references
         :mime-version:content-type:content-disposition:in-reply-to
         :user-agent;
        b=W6CVs9iOvP27RNxMI8XAybcAvC4WSMiXZKptGv0DHYUatFhmlfpVhjipeTxWU/hOke
         nmaDiz4t4jTzNsZN+M4rIszd05tuNURYfStvpFDQOhc7IPJx2lVpybcKbGDISv5foMDy
         vgsNrPkg99uGwZy60dBSscfCKIDct0VmaYPJY=
Date: Wed, 23 Feb 2011 15:24:43 +0300
From: Dan Carpenter <error27@gmail.com>
To: Martyn Welch <martyn.welch@ge.com>
Cc: Manohar Vanga <manohar.vanga@cern.ch>, devel@driverdev.osuosl.org,
        gregkh@suse.de, cota@braap.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] staging: vme: fix bug in vme_register_bridge
Message-ID: <20110223122443.GS1898@bicker>
Mail-Followup-To: Dan Carpenter <error27@gmail.com>,
	Martyn Welch <martyn.welch@ge.com>,
	Manohar Vanga <manohar.vanga@cern.ch>, devel@driverdev.osuosl.org,
	gregkh@suse.de, cota@braap.org, linux-kernel@vger.kernel.org
References: <1298453209-30821-1-git-send-email-manohar.vanga@cern.ch>
 <4D64D70A.1060007@ge.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4D64D70A.1060007@ge.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 970
Lines: 31

On Wed, Feb 23, 2011 at 09:44:42AM +0000, Martyn Welch wrote:
> On 23/02/11 09:26, Manohar Vanga wrote:
> > Fix a bug in vme_register_bridge that results in an infinite loop in
> > the event that device_register fails.

[snip]

> > +	/*
> > +	 * Ignore the failed device and unregister the rest.
> > +	 */
> > +	i--;
> >  	while (i > -1) {
> >  		dev = &bridge->dev[i];
> >  		device_unregister(dev);
> > +		i--;
> >  	}

Ah.  I see you fixed the bug already.  Good deal.  Btw, no need to add
comments for the obvious stuff.

You still aren't CCing the right list, devel@driverdev.osuosl.org.
It's not enough for Martyn to sent it to us, because by that point 
the patch has '> ' chars on every line.

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/