Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754775Ab1BWNR6 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 23 Feb 2011 08:17:58 -0500
Received: from cavan.codon.org.uk ([93.93.128.6]:35732 "EHLO
	cavan.codon.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754335Ab1BWNR5 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 23 Feb 2011 08:17:57 -0500
Date: Wed, 23 Feb 2011 13:17:34 +0000
From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Narendra_K@Dell.com
Cc: viro@zeniv.linux.org.uk, jbarnes@virtuousgeek.org, sfr@canb.auug.org.au,
        linux-kernel@vger.kernel.org, linux-next@vger.kernel.org,
        Shyam_Iyer@Dell.com, Matt_Domsch@Dell.com, Charles_Rose@Dell.com,
        Jordan_Hargrave@Dell.com
Subject: Re: [PATCH] Fix build failure when CONFIG_NLS is set to 'm' by
	allmodconfig
Message-ID: <20110223131734.GA6275@srcf.ucam.org>
References: <20110223131536.GA16707@fedora14-r610.blr.amer.dell.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20110223131536.GA16707@fedora14-r610.blr.amer.dell.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
X-SA-Exim-Connect-IP: <locally generated>
X-SA-Exim-Mail-From: mjg59@cavan.codon.org.uk
X-SA-Exim-Scanned: No (on cavan.codon.org.uk); SAEximRunCond expanded to false
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1362
Lines: 50

On Wed, Feb 23, 2011 at 06:24:31PM +0530, Narendra_K@Dell.com wrote:

> This patch fixes the following build breakage introduced by the patch
> '[PATCH V3] Export ACPI _DSM provided firmware instance number and string to
> sysfs'.

First, you should include this as part of your original patch so that 
the build doesn't break during bisection.

> This is fixed by making fs/nls/nls_base.c compile conditionally into
> vmlinux by introducing a new config option CONFIG_NLS_BASE which is
> selected by (ACPI || DMI || NLS).

Why?

> -obj-$(CONFIG_NLS)		+= nls/
> +obj-y				+= nls/

You seem to have just broken building any of the NLS code as modules.

>  menuconfig NLS
>  	tristate "Native language support"
> +	select NLS_BASE

All CONFIG_NLS does is build nls_base.

> +config NLS_BASE
> +	bool "Base NLS functions"
> +	depends on ACPI || DMI

What in this code depends on ACPI or DMI?

> -obj-$(CONFIG_NLS)		+= nls_base.o
> +obj-$(CONFIG_NLS_BASE)		+= nls_base.o

And why make this change?

Just have something like

select NLS if (ACPI || DMI)

in drivers/pci/Kconfig.

-- 
Matthew Garrett | mjg59@srcf.ucam.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/