Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752877Ab1BWPA7 (ORCPT ); Wed, 23 Feb 2011 10:00:59 -0500 Received: from ra.se.axis.com ([195.60.68.13]:45343 "EHLO ra.se.axis.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750806Ab1BWPA5 (ORCPT ); Wed, 23 Feb 2011 10:00:57 -0500 Date: Wed, 23 Feb 2011 16:00:47 +0100 From: Jesper Nilsson To: Linus Torvalds Cc: Dmitry Torokhov , Benjamin Herrenschmidt , Rusty Russell , David Miller , "linux-kernel@vger.kernel.org" , "geert@linux-m68k.org" , "linux-m68k@vger.kernel.org" , "linux-arch@vger.kernel.org" , Mikael Starvik Subject: Re: [PATCH 1/3] module: deal with alignment issues in built-in module versions Message-ID: <20110223150047.GC13204@axis.com> References: <20110217.142320.102554706.davem@davemloft.net> <1298074455.2460.85.camel@pasglop> <87pqqmrq9q.fsf@rustcorp.com.au> <1298339909.8833.135.camel@pasglop> <20110222070240.GA21765@dtor-ws.eng.vmware.com> <20110222170849.GW13204@axis.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1982 Lines: 59 On Tue, Feb 22, 2011 at 09:47:09PM +0100, Linus Torvalds wrote: > On Tue, Feb 22, 2011 at 9:08 AM, Jesper Nilsson wrote: > > True, at least until I've made sure that there isn't any > > underlying reason for CRISv32 to put __param in a different place... > > > > Acked-by: Jesper Nilsson > > I really am not going to apply a patch that likely just adds another > redundant field to the linker scripts. So the ack I'm just ignoring, :-) > But it would be good to get the "remove the legacy __param thing > because it's already there from the asm-generic version" confirmed by > testing, and not just looking at the source code. Testing shows no problems with the below patch. >From f8c17a94940a012f237986b4f40ca557a88f9019 Mon Sep 17 00:00:00 2001 From: Jesper Nilsson Date: Wed, 23 Feb 2011 13:04:25 +0100 Subject: [PATCH] Drop redundant __param section for CRISv32. The __param section is already brought in by RODATA above. Signed-off-by: Jesper Nilsson --- arch/cris/kernel/vmlinux.lds.S | 5 ----- 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/arch/cris/kernel/vmlinux.lds.S b/arch/cris/kernel/vmlinux.lds.S index 917b727..e8adc35 100644 --- a/arch/cris/kernel/vmlinux.lds.S +++ b/arch/cris/kernel/vmlinux.lds.S @@ -75,11 +75,6 @@ SECTIONS INIT_TEXT_SECTION(PAGE_SIZE) .init.data : { INIT_DATA } .init.setup : { INIT_SETUP(16) } -#ifdef CONFIG_ETRAX_ARCH_V32 - __start___param = .; - __param : { *(__param) } - __stop___param = .; -#endif .initcall.init : { INIT_CALLS } -- 1.7.4 > Linus /^JN - Jesper Nilsson -- Jesper Nilsson -- jesper.nilsson@axis.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/