Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754838Ab1BWQ1E (ORCPT ); Wed, 23 Feb 2011 11:27:04 -0500 Received: from rcsinet10.oracle.com ([148.87.113.121]:47560 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754657Ab1BWQ1C (ORCPT ); Wed, 23 Feb 2011 11:27:02 -0500 To: Dave Chinner Cc: "Darrick J. Wong" , Andreas Dilger , Jens Axboe , linux-kernel , "linux-fsdevel\@vger.kernel.org" , Mingming Cao , linux-scsi Subject: Re: [RFC] block integrity: Fix write after checksum calculation problem From: "Martin K. Petersen" Organization: Oracle References: <20110222020022.GH32261@tux1.beaverton.ibm.com> <180713DB-114C-454B-A91E-063AB0116251@dilger.ca> <20110222194538.GU27190@tux1.beaverton.ibm.com> <20110222225351.GG3166@dastard> Date: Wed, 23 Feb 2011 11:24:50 -0500 In-Reply-To: <20110222225351.GG3166@dastard> (Dave Chinner's message of "Wed, 23 Feb 2011 09:53:51 +1100") Message-ID: User-Agent: Gnus/5.110013 (No Gnus v0.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: acsmt354.oracle.com [141.146.40.154] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090205.4D653504.00F6:SCFMA4539814,ss=1,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1416 Lines: 32 >>>>> "Dave" == Dave Chinner writes: >> Agreed. I too am curious to study which circumstances favor copying >> vs blocking. Dave> IMO blocking is generally preferable in high throughput threaded Dave> workloads as there is always another thread that can do useful Dave> work while we wait for IO to complete. Most use cases for DIF Dave> center around high throughput environments.... Yeah. A while back I did a bunch of tests with a liberal amount of wait_on_page_writeback() calls added to (I think) ext2, ext3, and XFS. For my regular workloads there was no measurable change (kernel builds, random database and I/O tests). I'm sure we'll unearth some apps that will suffer when DI is on but so far I'm not too worried about blocking in the data path. My main concern is wrt. metadata because that's where extN really hurts. Simple test: Unpack a kernel tarball and watch the directory block fireworks. Given how frequently those buffers get hit I'm sure blocking would cause performance to tank completely. I looked into fixing this in ext2 but I had to stop because my eyes were bleeding. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/