Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755895Ab1BXGx5 (ORCPT ); Thu, 24 Feb 2011 01:53:57 -0500 Received: from TYO201.gate.nec.co.jp ([202.32.8.193]:62882 "EHLO tyo201.gate.nec.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755780Ab1BXGxy (ORCPT ); Thu, 24 Feb 2011 01:53:54 -0500 Date: Thu, 24 Feb 2011 15:47:45 +0900 From: Daisuke Nishimura To: Hugh Dickins Cc: KAMEZAWA Hiroyuki , Andrew Morton , Balbir Singh , Daisuke Nishimura , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] memcg: more mem_cgroup_uncharge batching Message-Id: <20110224154745.b7d7a0ac.nishimura@mxp.nes.nec.co.jp> In-Reply-To: References: Organization: NEC Soft, Ltd. X-Mailer: Sylpheed 3.1.0 (GTK+ 2.10.14; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 897 Lines: 20 On Wed, 23 Feb 2011 21:44:33 -0800 (PST) Hugh Dickins wrote: > It seems odd that truncate_inode_pages_range(), called not only when > truncating but also when evicting inodes, has mem_cgroup_uncharge_start > and _end() batching in its second loop to clear up a few leftovers, but > not in its first loop that does almost all the work: add them there too. > > Signed-off-by: Hugh Dickins Thank you catching this. This patch has already got enough ack's, but anyway: Acked-by: Daisuke Nishimura P.S. My address is "nishimura@mxp.nes.nec.co.jp", not "nishmura@mxp.nes.nec.co.jp" :) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/