Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932622Ab1BXG5V (ORCPT ); Thu, 24 Feb 2011 01:57:21 -0500 Received: from cn.fujitsu.com ([222.73.24.84]:62638 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S932547Ab1BXG5T (ORCPT ); Thu, 24 Feb 2011 01:57:19 -0500 Message-ID: <4D6601B2.1090207@cn.fujitsu.com> Date: Thu, 24 Feb 2011 14:58:58 +0800 From: Li Zefan User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.9) Gecko/20100921 Fedora/3.1.4-1.fc14 Thunderbird/3.1.4 MIME-Version: 1.0 To: Andrew Morton CC: Paul Menage , David Rientjes , =?UTF-8?B?57yqIOWLsA==?= , LKML , linux-mm@kvack.org Subject: [PATCH] cpuset: Add a missing unlock in cpuset_write_resmask() X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.1FP4|July 25, 2010) at 2011-02-24 14:56:15, Serialize by Router on mailserver/fnst(Release 8.5.1FP4|July 25, 2010) at 2011-02-24 14:56:15, Serialize complete at 2011-02-24 14:56:15 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 856 Lines: 30 Don't forget to release cgroup_mutex if alloc_trial_cpuset() fails. Signed-off-by: Li Zefan --- kernel/cpuset.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/kernel/cpuset.c b/kernel/cpuset.c index 1ca786a..6272503 100644 --- a/kernel/cpuset.c +++ b/kernel/cpuset.c @@ -1561,8 +1561,10 @@ static int cpuset_write_resmask(struct cgroup *cgrp, struct cftype *cft, return -ENODEV; trialcs = alloc_trial_cpuset(cs); - if (!trialcs) + if (!trialcs) { + cgroup_unlock(); return -ENOMEM; + } switch (cft->private) { case FILE_CPULIST: -- 1.7.3.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/